From 7edae8dce55c260c91f436c8571c5aef70b18a08 Mon Sep 17 00:00:00 2001 From: Marko Ivankovic Date: Wed, 11 Nov 2026 08:57:04 +0100 Subject: [PATCH 1/2] ci: build cargo-generate-rpm from source in the release install-action has no checksummed manifest entry for it, so it fell back to an unpinned cargo-binstall, which fetched a binary QuickInstall built. That binary writes the .rpm the release attests. cargo install --locked builds the published crate instead. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01FNs394W7GMp53qrHNPrACN --- .github/workflows/ci.yml | 7 ++++--- .github/workflows/release.yml | 11 ++++++++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c882e32..fb9007a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -383,9 +383,10 @@ jobs: sudo apt-get update sudo apt-get install --no-install-recommends -y musl-tools rpm createrepo-c - - uses: taiki-e/install-action@682ce6c3c696a4cd5168a05f98e51aa02b877941 # v2.89.1 - with: - tool: cargo-generate-rpm@0.21.1 + # From source, as release.yml installs it and for its reason: it is not + # in install-action's checksummed manifest. + - name: Install cargo-generate-rpm + run: cargo install --locked cargo-generate-rpm --version 0.21.1 - name: Build the packages env: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 40ad380..fd8bdca 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -123,10 +123,15 @@ jobs: with: tool: cargo-deb + # From source, not through install-action. install-action verifies a + # checksum only for the tools in its own manifest, and this is not one: + # it fell back to an unpinned cargo-binstall, which fetched a binary + # built by QuickInstall, a third party. That binary would write the + # .rpm this workflow attests. `cargo install --locked` builds the + # published crate against its own lockfile, every crate checked + # against the crates.io index, and costs about a minute. - name: Install cargo-generate-rpm - uses: taiki-e/install-action@682ce6c3c696a4cd5168a05f98e51aa02b877941 # v2.89.1 - with: - tool: cargo-generate-rpm@0.21.1 + run: cargo install --locked cargo-generate-rpm --version 0.21.1 # The target-specific `CC_*` rather than a bare `CC`: build scripts and # proc macros are compiled for the *host*, and pointing their C compiler From f1bd8fb5253155a5446e9e27a0bfabf998431b3d Mon Sep 17 00:00:00 2001 From: Marko Ivankovic Date: Wed, 11 Nov 2026 09:07:36 +0100 Subject: [PATCH 2/2] ci: install cargo-generate-rpm outside the cached ~/.cargo/bin rust-cache had restored QuickInstall's binary there, and cargo install then skipped the build as already installed. Install to a directory of its own, and remove the cached copy in CI. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01FNs394W7GMp53qrHNPrACN --- .github/workflows/ci.yml | 9 ++++++++- .github/workflows/release.yml | 10 ++++++++-- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fb9007a..1402291 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -385,8 +385,15 @@ jobs: # From source, as release.yml installs it and for its reason: it is not # in install-action's checksummed manifest. + # Outside ~/.cargo/bin, which rust-cache restores: a cached copy is + # how the first version of this step ran QuickInstall's binary anyway. + # The `rm` removes that copy from caches saved before this change. - name: Install cargo-generate-rpm - run: cargo install --locked cargo-generate-rpm --version 0.21.1 + run: | + rm -f "$HOME/.cargo/bin/cargo-generate-rpm" + cargo install --locked cargo-generate-rpm --version 0.21.1 \ + --root "$RUNNER_TEMP/cargo-generate-rpm" + echo "$RUNNER_TEMP/cargo-generate-rpm/bin" >> "$GITHUB_PATH" - name: Build the packages env: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fd8bdca..c22b0f8 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -129,9 +129,15 @@ jobs: # built by QuickInstall, a third party. That binary would write the # .rpm this workflow attests. `cargo install --locked` builds the # published crate against its own lockfile, every crate checked - # against the crates.io index, and costs about a minute. + # against the crates.io index, and costs about a minute. Into a + # directory of its own rather than ~/.cargo/bin, which rust-cache + # saves and restores in ci.yml, so neither workflow can end up running + # a binary some earlier run left there. - name: Install cargo-generate-rpm - run: cargo install --locked cargo-generate-rpm --version 0.21.1 + run: | + cargo install --locked cargo-generate-rpm --version 0.21.1 \ + --root "$RUNNER_TEMP/cargo-generate-rpm" + echo "$RUNNER_TEMP/cargo-generate-rpm/bin" >> "$GITHUB_PATH" # The target-specific `CC_*` rather than a bare `CC`: build scripts and # proc macros are compiled for the *host*, and pointing their C compiler