Skip to content

Commit 724a786

Browse files
committed
ROADMAP ultraworkers#137: model-alias shorthand regression in test suite — bare alias parsing broken on feat/134-135-session-identity; 3 tests fail with invalid model syntax error after ultraworkers#134/ultraworkers#135 validation tightening
1 parent 91ba54d commit 724a786

1 file changed

Lines changed: 19 additions & 0 deletions

File tree

ROADMAP.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -830,6 +830,25 @@ Acceptance:
830830
- channel status updates stay short and machine-grounded
831831
- claws stop inferring state from raw build spam
832832

833+
### 137. Model-alias shorthand regression in test suite — bare alias parsing broken on `feat/134-135-session-identity` branch
834+
835+
**Filed:** 2026-04-21 from dogfood cycle — `cargo test --workspace` on `feat/134-135-session-identity` HEAD (`91ba54d`) shows 3 failing tests.
836+
837+
**Problem:** `tests::parses_bare_prompt_and_json_output_flag`, `tests::multi_word_prompt_still_uses_shorthand_prompt_mode`, and `tests::env_permission_mode_overrides_project_config_default` all panic with:
838+
```
839+
args should parse: "invalid model syntax: 'claude-opus'. Expected provider/model (e.g., anthropic/claude-opus-4-6) or known alias (opus, sonnet, haiku)"
840+
```
841+
The #134/#135 session-identity work tightened model-syntax validation but the test fixtures still pass bare `claude-opus` style strings that the new validator rejects. 162 tests pass; only the three tests using legacy bare-alias model names fail.
842+
843+
**Fix shape:**
844+
- Update the three failing test fixtures to use either a valid alias (`opus`, `sonnet`, `haiku`) or a fully-qualified model id (`anthropic/claude-opus-4-6`)
845+
- Alternatively, if `claude-opus` is an intended supported alias, add it to the alias registry
846+
- Verify `cargo test --workspace` returns 0 failures before merging the feat branch to `main`
847+
848+
**Acceptance:**
849+
- `cargo test --workspace` passes with 0 failures on the `feat/134-135-session-identity` branch
850+
- No regression on the 162 tests currently passing
851+
833852
### 133. Blocked-state subphase contract (was §6.5)
834853
**Filed:** 2026-04-20 from dogfood cycle — previous cycle identified §4.44.5 provenance gap, this cycle targets §6.5 implementation.
835854

0 commit comments

Comments
 (0)