Skip to content

GetFileQuery declares unused Height/Width resize params (dead/misleading feature) #46

Description

@umerfaruk

Summary

The file-download API accepts/declares thumbnail resize dimensions that are never actually applied.

Details

`FileController.GetFile`/`GetLibraryFile` always pass `Height = 200, Width = 200` to `GetFileQuery`, but the resizing implementation in `GetFileRequestHandler.ExecuteAsync` (src/Inshapardaz.Domain/Ports/Query/File/GetFileQuery.cs:34-51) is commented out with `// TODO : Implementation needed`.

Impact

The API silently returns full-size images regardless of the requested dimensions, which is misleading for anything relying on the declared contract.

Suggested fix

Either implement the resize (using the already-referenced image library) or remove the unused `Height`/`Width` parameters so the contract matches actual behavior.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions