From 3c9a0d75d2978defdbdf354cc4acf20ece3351d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9o=20FIDRY?= Date: Tue, 21 Apr 2026 11:31:08 +0200 Subject: [PATCH 1/3] build: Remove unused arguments for PHPUnit Currently executing PHPUnit will generate clover, JUnit and XML coverage reports in `build/logs`, which is should be changed for `var` (see #45). However, I noticed that none of those reports are actually used, neither in the CI, neither by infection (it executes the tests itself). Hence instead of changing the directory this PR removes them entirely. --- Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Makefile b/Makefile index cec7399..f7da877 100644 --- a/Makefile +++ b/Makefile @@ -16,8 +16,6 @@ PHP_CS_FIXER_URL="https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download # PHPUnit PHPUNIT=vendor/bin/phpunit -PHPUNIT_COVERAGE_CLOVER=--coverage-clover=build/logs/clover.xml -PHPUNIT_ARGS=--coverage-xml=build/logs/coverage-xml --log-junit=build/logs/junit.xml $(PHPUNIT_COVERAGE_CLOVER) # PHPStan PHPSTAN=vendor/bin/phpstan @@ -69,7 +67,7 @@ phpstan: .PHONY: test-unit test-unit: vendor/autoload.php - $(PHPUNIT) $(PHPUNIT_ARGS) + $(PHPUNIT) .PHONY: test-e2e test-e2e: vendor/autoload.php From 133161471ac83bf38630662fd6d86569a6a87f34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9o=20FIDRY?= Date: Tue, 21 Apr 2026 11:38:08 +0200 Subject: [PATCH 2/3] Revert "build: Remove unused arguments for PHPUnit" This reverts commit 3c9a0d75d2978defdbdf354cc4acf20ece3351d9. --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index f7da877..cec7399 100644 --- a/Makefile +++ b/Makefile @@ -16,6 +16,8 @@ PHP_CS_FIXER_URL="https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download # PHPUnit PHPUNIT=vendor/bin/phpunit +PHPUNIT_COVERAGE_CLOVER=--coverage-clover=build/logs/clover.xml +PHPUNIT_ARGS=--coverage-xml=build/logs/coverage-xml --log-junit=build/logs/junit.xml $(PHPUNIT_COVERAGE_CLOVER) # PHPStan PHPSTAN=vendor/bin/phpstan @@ -67,7 +69,7 @@ phpstan: .PHONY: test-unit test-unit: vendor/autoload.php - $(PHPUNIT) + $(PHPUNIT) $(PHPUNIT_ARGS) .PHONY: test-e2e test-e2e: vendor/autoload.php From 4fa8a6794019c8ea96325bd89b31c4e08549e911 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9o=20FIDRY?= Date: Tue, 21 Apr 2026 11:39:00 +0200 Subject: [PATCH 3/3] update clover path --- .github/workflows/tests.yaml | 2 +- Makefile | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 4ae7d87..17a3b4e 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -71,7 +71,7 @@ jobs: - name: Upload coverage results to Coveralls env: COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: vendor/bin/php-coveralls + run: vendor/bin/php-coveralls --coverage_clover=var/phpunit-clover.xml e2e: runs-on: ubuntu-latest diff --git a/Makefile b/Makefile index cec7399..d92b1d9 100644 --- a/Makefile +++ b/Makefile @@ -16,8 +16,7 @@ PHP_CS_FIXER_URL="https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download # PHPUnit PHPUNIT=vendor/bin/phpunit -PHPUNIT_COVERAGE_CLOVER=--coverage-clover=build/logs/clover.xml -PHPUNIT_ARGS=--coverage-xml=build/logs/coverage-xml --log-junit=build/logs/junit.xml $(PHPUNIT_COVERAGE_CLOVER) +PHPUNIT_ARGS=--coverage-clover=var/phpunit-clover.xml # PHPStan PHPSTAN=vendor/bin/phpstan