S3 for Public Feed Downloads#652
Open
binh-dam-ibigroup wants to merge 18 commits into
Open
Conversation
This reverts commit 6378872.
br648
approved these changes
Jun 5, 2026
| s3client = builder.build(); | ||
| } catch (Exception e) { | ||
| LOG.error( | ||
| "S3 client not initialized correctly. Must provide config property {} or specify region in ~/.aws/config", |
Contributor
There was a problem hiding this comment.
Nit. Remove additional space before Must
| /** | ||
| * Implements the default behavior for above interface. | ||
| * This method uses extensions.mtc.s3_credentials_file and s3_region, if populated, | ||
| * and falls back to . |
| url = S3Utils.getDefaultBucketUrlForKey(fs.toPublicKey()); | ||
| } | ||
| r.append("<li>"); | ||
| r.append("<a href=\"" + url + "\">"); |
Contributor
There was a problem hiding this comment.
Consider using the appender instead of + : r.append("<a href=\"").append(url).append("\">");. Same for lines 94 and 97.
Contributor
Author
There was a problem hiding this comment.
Updated in 7f138f0 although I wasn't initially planning to touch that.
| } | ||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(booleans = { false, true }) |
Contributor
Author
We have an internal backlog ticket for that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR adds support for the use of S3 bucket for public feed hosting, even if S3 is not used for storing feed versions for internal DataTools use.
Behind the scenes, support is added for alternate S3 credentials, region, and bucket for the MTCFeedResource and FeedUpdater that, if specified, override the application's ones: