From 1cae651da7a27b88faae8fee7057b74f1e4bc398 Mon Sep 17 00:00:00 2001 From: Daniel Jeans Date: Tue, 29 Nov 2022 15:38:46 +0900 Subject: [PATCH 1/2] remove overwriting of input parameters in TVSurface::CalcXingPointWith --- src/geomlib/TVSurface.cxx | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/geomlib/TVSurface.cxx b/src/geomlib/TVSurface.cxx index 326be83..650346b 100644 --- a/src/geomlib/TVSurface.cxx +++ b/src/geomlib/TVSurface.cxx @@ -48,11 +48,10 @@ Int_t TVSurface::CalcXingPointWith(const TVTrack &hel, Int_t mode, Double_t eps) const { - eps = 1.e-5; - + // eps = 1.e-5; // do we really want to ignore the input value? // this Newtonian method is used for non-uniform b field, // for this case mode is currently set to 0 - mode = 0; + // mode = 0; // do we really want to ignore the input value? static const Int_t maxcount = 100; static const Double_t initlambda = 1.e-10; From 726bf9d16421e0a2e52e555c92ad155443248f5d Mon Sep 17 00:00:00 2001 From: Daniel Jeans Date: Tue, 13 Dec 2022 16:55:34 +0900 Subject: [PATCH 2/2] change default eps to 1e-5 (to match previously hardcoded value) --- src/geomlib/TVSurface.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/geomlib/TVSurface.h b/src/geomlib/TVSurface.h index be0a085..3717f77 100644 --- a/src/geomlib/TVSurface.h +++ b/src/geomlib/TVSurface.h @@ -36,12 +36,12 @@ class TVSurface : public TObject { virtual Int_t CalcXingPointWith(const TVTrack &hel, TVector3 &xx, Double_t &phi, - Double_t eps = 1.e-8) const; + Double_t eps = 1.e-5) const; virtual Int_t CalcXingPointWith(const TVTrack &hel, TVector3 &xx, Double_t &phi, Int_t mode, - Double_t eps = 1.e-8) const; + Double_t eps = 1.e-5) const; virtual Double_t CalcS (const TVector3 &xx) const = 0; virtual TMatrixD CalcDSDx (const TVector3 &xx) const = 0;