From 92126fd4efe0024fd22285f47e414b11068900ef Mon Sep 17 00:00:00 2001
From: "Jonathan D.A. Jewell" <6759885+hyperpolymath@users.noreply.github.com>
Date: Wed, 12 Aug 2026 01:14:09 +0100
Subject: [PATCH] fix(ci): make fake gates real and add Elixir lint gate

Fixes for issue #694:

1. tests.yml: Fix E2E Rust CLI Scan
   - Changed 'hyper' to 'hypatia' (correct binary name)
   - Removed '|| true' so the step can fail properly

2. quality.yml: Fix lint job that cannot fail
   - Removed '|| true' from Check file permissions step
   - Removed '|| echo "None found"' from Check TODO/FIXME step
   - Removed '|| echo "No large files"' from Check for large files step
   - Removed 'continue-on-error: true' from EditorConfig check step
   - Removed '--include="*.res"' from grep (zero .res files in repo)

3. tests.yml: Add Elixir lint gate
   - Added 'mix compile --warnings-as-errors' step to e2e-elixir job
   - This addresses the 21 warnings mentioned in issue #694

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
---
 .github/workflows/quality.yml | 7 +++----
 .github/workflows/tests.yml   | 5 ++++-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/quality.yml b/.github/workflows/quality.yml
index 12cb18d2..584545db 100644
--- a/.github/workflows/quality.yml
+++ b/.github/workflows/quality.yml
@@ -325,20 +325,19 @@ jobs:
       
       - name: Check file permissions
         run: |
-          find . -type f -perm /111 -name "*.sh" | head -10 || true
+          find . -type f -perm /111 -name "*.sh" | head -10
       
       - name: Check TODO/FIXME
         run: |
           echo "=== TODOs ==="
-          grep -rn "TODO\|FIXME\|HACK\|XXX" --include="*.rs" --include="*.res" --include="*.py" --include="*.ex" . | head -20 || echo "None found"
+          grep -rn "TODO\|FIXME\|HACK\|XXX" --include="*.rs" --include="*.py" --include="*.ex" . | head -20
       
       - name: Check for large files
         run: |
-          find . -type f -size +1M -not -path "./.git/*" | head -10 || echo "No large files"
+          find . -type f -size +1M -not -path "./.git/*" | head -10
       
       - name: EditorConfig check
         uses: editorconfig-checker/action-editorconfig-checker@v2.2.0
-        continue-on-error: true
 
   docs:
     runs-on: ubuntu-latest
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 934ef841..b1e90bb9 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -50,6 +50,9 @@ jobs:
       - name: Install dependencies
         run: mix deps.get
 
+      - name: Elixir lint gate
+        run: mix compile --warnings-as-errors
+
       - name: Run E2E test suite
         run: bash tests/e2e.sh
 
@@ -92,7 +95,7 @@ jobs:
           echo '    runs-on: ubuntu-latest' >> /tmp/test-repo/.github/workflows/ci.yml
           echo '    steps:' >> /tmp/test-repo/.github/workflows/ci.yml
           echo '      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.2.2' >> /tmp/test-repo/.github/workflows/ci.yml
-          ./target/release/hyper scan /tmp/test-repo 2>&1 || true
+          ./target/release/hypatia scan /tmp/test-repo 2>&1
           echo "PASS: Rust CLI scan completed"
 
   aspect-tests: