fix: exception flushing issue during sdk shutdown (#157)

* fix: sdk exception flushing issue

* style: remove some benchmarks

* docs: type

* docs: add changeset

Author: wrn14897

.changeset/proud-nails-worry.md

@@ -0,0 +1,6 @@
+---
+'@hyperdx/instrumentation-exception': patch
+'@hyperdx/node-opentelemetry': patch
+---
+
+fix: sdk shutdown exception flushing issue

packages/instrumentation-exception/src/instrumentation.ts

@@ -62,14 +62,15 @@ export class ExceptionInstrumentation extends InstrumentationBase {
 
   override enable() {
     const config = this.getConfig();
+    const ff = config._internalForceFlush ?? this.forceFlush;
     onUncaughtExceptionIntegration({
       exitEvenIfOtherHandlersAreRegistered:
         config.exitEvenIfOtherHandlersAreRegistered,
-      forceFlush: () => this.forceFlush(),
+      forceFlush: () => ff(),
     }).setup({} as any);
     onUnhandledRejectionIntegration({
       mode: config.unhandledRejectionMode,
-      forceFlush: () => this.forceFlush(),
+      forceFlush: () => ff(),
     }).setup({} as any);
   }
 

packages/instrumentation-exception/src/types.ts

@@ -12,6 +12,9 @@ export interface EventCustomAttributeFunction {
  * Options available for the Exception Instrumentation (see [documentation]())
  */
 export interface ExceptionInstrumentationConfig extends InstrumentationConfig {
+  // INTERNAL USE ONLY
+  _internalForceFlush?: () => Promise<void>;
+
   /**
    * Controls if the SDK should register a handler to exit the process on uncaught errors:
    * - `true`: The SDK will exit the process on all uncaught errors.

packages/node-opentelemetry/src/otel.ts

@@ -228,14 +228,12 @@ export const initSDK = (config: SDKConfig) => {
   //--------------------------------------------------
   // ------------------- LOGGER ----------------------
   //--------------------------------------------------
-  let _t = process.hrtime();
   ui.text = 'Initializing OpenTelemetry Logger...';
   const _logger = new OtelLogger({
     detectResources: defaultDetectResources,
     service: defaultServiceName,
   });
-  const t0 = process.hrtime(_t);
-  ui.succeed(`Initialized OpenTelemetry Logger in ${hrtimeToMs(t0)} ms`);
+  ui.succeed('Initialized OpenTelemetry Logger');
   //--------------------------------------------------
 
   // Health check
@@ -318,7 +316,13 @@ export const initSDK = (config: SDKConfig) => {
     ...(defaultSentryIntegrationEnabled
       ? [new SentryNodeInstrumentation()]
       : []),
-    ...(defaultExceptionCapture ? [new ExceptionInstrumentation()] : []),
+    ...(defaultExceptionCapture
+      ? [
+          new ExceptionInstrumentation({
+            _internalForceFlush: shutdown,
+          }),
+        ]
+      : []),
     ...(config.additionalInstrumentations ?? []),
   ];
 
@@ -350,8 +354,7 @@ export const initSDK = (config: SDKConfig) => {
     contextManager: contextManager,
   });
 
-  const t1 = process.hrtime(_t);
-  ui.succeed(`Initialized instrumentations packages in ${hrtimeToMs(t1)} ms`);
+  ui.succeed('Initialized instrumentations packages');
 
   if (defaultEnableInternalProfiling) {
     ui.text = 'Enabling internal profiling...';
@@ -412,14 +415,11 @@ export const initSDK = (config: SDKConfig) => {
     }
   }
 
-  _t = process.hrtime();
   ui.text = 'Starting OpenTelemetry Node SDK...';
   sdk.start();
-  const t2 = process.hrtime(_t);
-  ui.succeed(`Started OpenTelemetry Node SDK in ${hrtimeToMs(t2)} ms`);
+  ui.succeed('Started OpenTelemetry Node SDK');
 
   if (config.programmaticImports) {
-    _t = process.hrtime();
     ui.text = 'Repatching instrumentation packages...';
     for (const instrumentation of allInstrumentations) {
       const modules = (instrumentation as any)
@@ -526,8 +526,7 @@ export const initSDK = (config: SDKConfig) => {
         }
       }
     }
-    const t3 = process.hrtime(_t);
-    ui.succeed(`Repatched instrumentation packages in ${hrtimeToMs(t3)} ms`);
+    ui.succeed('Repatched instrumentation packages');
   }
 
   function handleTerminationSignal(signal: string) {