cmp-path doesn't work for me from commit 61e531bd3e52573f5623531051986edb2e51f850

[nipun-ghanathe]

I recently updated cmp-path and from then on it didn't seem to work. Other sources were working fine in nvim-cmp. I tried to use previous commits. And found that commit "584414b" was working fine for me.

In commits "61e531b" and "99c4981" no source works as I get this error:

Error detected while processing TextChangedI Autocommands for "*":
Error executing lua callback: ...un/.local/share/nvim/lazy/cmp-path/lua/cmp_path/init.lua:242: pathMappings: expected table, got nil
stack traceback:
        [C]: in function 'error'
        vim/shared.lua:936: in function 'validate'
        ...un/.local/share/nvim/lazy/cmp-path/lua/cmp_path/init.lua:242: in function '_validate_option'
        ...un/.local/share/nvim/lazy/cmp-path/lua/cmp_path/init.lua:40: in function 'complete'
        ...nipun/.local/share/nvim/lazy/nvim-cmp/lua/cmp/source.lua:342: in function 'complete'
        ...e/nipun/.local/share/nvim/lazy/nvim-cmp/lua/cmp/core.lua:308: in function 'complete'
        ...e/nipun/.local/share/nvim/lazy/nvim-cmp/lua/cmp/core.lua:178: in function 'callback'
        ...e/nipun/.local/share/nvim/lazy/nvim-cmp/lua/cmp/core.lua:238: in function 'autoindent'
        ...e/nipun/.local/share/nvim/lazy/nvim-cmp/lua/cmp/core.lua:170: in function 'on_change'
        ...e/nipun/.local/share/nvim/lazy/nvim-cmp/lua/cmp/init.lua:372: in function 'callback'
        ...local/share/nvim/lazy/nvim-cmp/lua/cmp/utils/autocmd.lua:53: in function 'emit'
        ...local/share/nvim/lazy/nvim-cmp/lua/cmp/utils/autocmd.lua:14: in function <...local/share/nvim/lazy/nvim-cmp/lua/cmp/utils/autocmd.lua:13>

After those commits, from commit "aa330b5", other sources work properly and I don't get the above error, but now I don't get entries from cmp-path.

[AnthonyK213]

Do we really need this feature #83 ? I didn't get it.

[RayGuo-ergou]

I think it implemented in a way that ONLY support alias as in if there's no alias it would not work: 61e531b

cc @kola-web correct me if im wrong, I think alias should be an extend feature not override the existing.

[RayGuo-ergou]

@nipun-ghanathe try to pass one alias to path_mappings it should work as the register function now loop though that table.

[kola-web]

@nipun-ghanathe try to pass one alias to path_mappings it should work as the register function now loop though that table.

How you configured it

[RayGuo-ergou]

I think the ideal solution here is to handle when path_mappings is empty

[kola-web]

I think it implemented in a way that ONLY support alias as in if there's no alias it would not work: 61e531b

cc @kola-web correct me if im wrong, I think alias should be an extend feature not override the existing.

Yes, it only supports aliases, and path_mappings should be used instead of pathMappings,I submitted a fixed PR that hasn't been merged yet

[RayGuo-ergou]

Yes but your PR only fixes the typo in readme. However, I still think we should not break the whole thing if path_mappings is empty.

[kola-web]

You mean that when the path_mappings is empty, it will cause the project to report an error, right?

[kola-web]

I commented it out and it didn't get an error, can you show me your configuration

[RayGuo-ergou]

Not an error, it will just not work, e.g. no completion items.

https://github.com/hrsh7th/cmp-path/blob/main/lua/cmp_path/init.lua#L53-L86

isn't that because it does not call get_candidates at all if the path_mapping is empty?

[AnthonyK213]

@kola-web Could you please clean up your code (tabs, quotes and naming convention) and describe the usage scenarios in readme? btw, the new option should be in the Configuration section, you took the center position, mate.

[kola-web]

My core purpose is to solve the problem of path alias reference files in webpack project and vite project. I have referenced the vscode plugin Path Autocomplete. Does it mean that I should explain the meaning of ${folder}

[AnthonyK213]

They should be written down to the readme, imagine how could a new user find the "reference"?

[kola-web]

${folder} refers to the root directory, as shown in the following configuration

path_mappings = {
    ['@'] = '${folder}/src',
}

Suppose there is a directory of project/src/assets/images/1.png
After entering @/, the assets directory will be prompted directly

Is that okay？

[RayGuo-ergou]

Sorry maybe not make it clear, this extend feature should NOT break the core.

e.g. It should check

source.complete = function(self, params, callback)
	if #path_mappings == 0 then
		--fallback to old behavior 
	end
	-- ....alias
end