error: too many arguments to function ‘isaac’ + ‘randinit’

[eserte]

The compilation fails on fedora 42:

cc -c  -I. -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -O2   -DVERSION=\"1.503\" -DXS_VERSION=\"1.503\" -fPIC "-I/opt/perl-5.41.13/lib/5.41.13/x86_64-linux/CORE"   Token.c
Token.xs: In function ‘get_new_byte’:
Token.xs:31:7: error: too many arguments to function ‘isaac’; expected 0, have 1
   31 |       isaac(&ctx->isaac_ctx);
      |       ^~~~~ ~~~~~~~~~~~~~~~
In file included from Token.xs:6:
rand.h:41:6: note: declared here
   41 | void isaac(/*_ randctx *r _*/);
      |      ^~~~~
Token.xs: In function ‘XS_Session__Token__new_context’:
Token.xs:84:9: error: too many arguments to function ‘randinit’; expected 0, have 2
   84 |         randinit(&ctx->isaac_ctx, TRUE);
      |         ^~~~~~~~ ~~~~~~~~~~~~~~~
rand.h:39:6: note: declared here
   39 | void randinit(/*_ randctx *r, word flag _*/);
      |      ^~~~~~~~
Token.xs:85:9: error: too many arguments to function ‘isaac’; expected 0, have 1
   85 |         isaac(&ctx->isaac_ctx);
      |         ^~~~~ ~~~~~~~~~~~~~~~
rand.h:41:6: note: declared here
   41 | void isaac(/*_ randctx *r _*/);
      |      ^~~~~
make: *** [Makefile:346: Token.o] Error 1

[hisdeedsaredust]

Fedora 42 includes GCC 15, which moves the default C standard upto gnu23. I also needed this module, so I fixed it locally by uncommenting the arguments from the declarations of randinit() and isaac() in rand.h. That will build successfully, albeit with a warning about the old-style function definitions in randport.c. Sorry that I don't know how to do a full fix without knowing how ancient a compiler the maintainer might wish to support.

[hoytech]

Sorry for the late response. I don't think we need to support anything too ancient. PR would be appreciated!