perf: drop now unused reverseNodeDependencies

Author: SukkaW

packages/shared/src/graph/__tests__/walk.test.ts

@@ -11,7 +11,6 @@ describe('walkTopological', () => {
   const makeGraph = (deps: Array<[string, Array<string>]>, nodes: Array<string>) => {
     const nodeDependencies = new Map<string, Set<string>>();
     const subtreeDependencies = new Map<string, Set<string>>();
-    const reverseNodeDependencies = new Map<string, Set<string>>();
     const nodesMap = new Map<string, any>();
 
     for (const name of nodes) {
@@ -22,16 +21,11 @@ describe('walkTopological', () => {
       const s = new Set<string>(toList);
       nodeDependencies.set(from, s);
       subtreeDependencies.set(from, new Set<string>(toList));
-      for (const to of toList) {
-        if (!reverseNodeDependencies.has(to)) reverseNodeDependencies.set(to, new Set());
-        reverseNodeDependencies.get(to)!.add(from);
-      }
     }
 
     return {
       nodeDependencies,
       nodes: nodesMap,
-      reverseNodeDependencies,
       subtreeDependencies,
       transitiveDependencies: new Map<string, Set<string>>(),
     } as unknown as Graph;
@@ -183,13 +177,11 @@ describe('walkTopological', () => {
     const nodeDependencies = new Map<string, Set<string>>();
     nodeDependencies.set(schema, new Set([param]));
     const subtreeDependencies = new Map<string, Set<string>>();
-    const reverseNodeDependencies = new Map<string, Set<string>>();
     const nodesMap = new Map<string, any>();
     for (const n of nodes) nodesMap.set(n, { key: null, node: {}, parentPointer: null });
     const graph = {
       nodeDependencies,
       nodes: nodesMap,
-      reverseNodeDependencies,
       subtreeDependencies,
       transitiveDependencies: new Map<string, Set<string>>(),
     } as unknown as Graph;
@@ -215,7 +207,6 @@ describe('walkTopological', () => {
     const graph = {
       nodeDependencies,
       nodes: nodesMap,
-      reverseNodeDependencies: new Map<string, Set<string>>(),
       subtreeDependencies: new Map<string, Set<string>>(),
       transitiveDependencies: new Map<string, Set<string>>(),
     } as unknown as Graph;
@@ -240,7 +231,6 @@ describe('walkTopological', () => {
     const graph = {
       nodeDependencies,
       nodes: nodesMap,
-      reverseNodeDependencies: new Map<string, Set<string>>(),
       subtreeDependencies,
       transitiveDependencies: new Map<string, Set<string>>(),
     } as unknown as Graph;

packages/shared/src/graph/types/graph.ts

@@ -5,7 +5,6 @@ import type { Scope } from '../../openApi/shared/utils/graph';
  *
  * @property nodeDependencies - For each node with at least one dependency, the set of normalized JSON Pointers it references via $ref. Nodes with no dependencies are omitted.
  * @property nodes - Map from normalized JSON Pointer to NodeInfo for every node in the spec.
- * @property reverseNodeDependencies - For each node with at least one dependent, the set of nodes that reference it via $ref. Nodes with no dependents are omitted.
  */
 export type Graph = {
   /**
@@ -17,11 +16,6 @@ export type Graph = {
    * Map from normalized JSON Pointer to NodeInfo for every node in the spec.
    */
   nodes: Map<string, NodeInfo>;
-  /**
-   * For each node with at least one dependent, the set of nodes that reference it via $ref.
-   * Nodes with no dependents are omitted from this map.
-   */
-  reverseNodeDependencies: Map<string, Set<string>>;
   /**
    * For each node, the set of direct $ref targets that appear anywhere inside the node's
    * subtree (the node itself and its children). This is populated during graph construction

packages/shared/src/openApi/shared/utils/__tests__/graph.test.ts

@@ -40,11 +40,6 @@ describe('buildGraph', () => {
     // Qux transitive deps should include Baz (and vice-versa because of the cycle)
     expect(graph.transitiveDependencies.get(qux)).toBeDefined();
     expect(Array.from(graph.transitiveDependencies.get(qux)!).sort()).toEqual([baz].sort());
-
-    // Reverse dependencies should reflect the mutual references
-    expect(graph.reverseNodeDependencies.get(qux)).toBeDefined();
-    expect(Array.from(graph.reverseNodeDependencies.get(qux)!).sort()).toEqual([baz].sort());
-    expect(Array.from(graph.reverseNodeDependencies.get(baz)!).sort()).toEqual([qux].sort());
   });
 
   it('handles a small hand-constructed tree with child-level $ref', () => {

packages/shared/src/openApi/shared/utils/graph.ts

@@ -246,14 +246,12 @@ export const seedLocalScopes = (nodes: Graph['nodes']): void => {
  * - All keys in the returned maps are normalized JSON Pointers (RFC 6901, always starting with '#').
  * - The `nodes` map allows fast lookup of any node and its parent/key context.
  * - The `dependencies` map records, for each node, the set of normalized pointers it references via $ref.
- * - The `reverseNodeDependencies` map records, for each node, the set of nodes that reference it via $ref.
  * - After construction, all nodes will have their local and propagated scopes annotated.
  *
  * @param root The root object (e.g., the OpenAPI spec)
  * @returns An object with:
  *   - nodes: Map from normalized JSON Pointer string to NodeInfo
  *   - dependencies: Map from normalized JSON Pointer string to Set of referenced normalized JSON Pointers
- *   - reverseNodeDependencies: Map from normalized JSON Pointer string to Set of referencing normalized JSON Pointers
  */
 export function buildGraph(
   root: unknown,
@@ -265,7 +263,6 @@ export function buildGraph(
   const graph: Graph = {
     nodeDependencies: new Map(),
     nodes: new Map(),
-    reverseNodeDependencies: new Map(),
     subtreeDependencies: new Map(),
     transitiveDependencies: new Map(),
   };
@@ -352,15 +349,6 @@ export function buildGraph(
     cache.parentToChildren.get(parent)!.push(pointer);
   }
 
-  for (const [pointerFrom, pointers] of graph.nodeDependencies) {
-    for (const pointerTo of pointers) {
-      if (!graph.reverseNodeDependencies.has(pointerTo)) {
-        graph.reverseNodeDependencies.set(pointerTo, new Set());
-      }
-      graph.reverseNodeDependencies.get(pointerTo)!.add(pointerFrom);
-    }
-  }
-
   seedLocalScopes(graph.nodes);
   propagateScopes(graph);
   annotateChildScopes(graph.nodes);