feat: use log.warn from codegen-core and handle function values in dedup

Author: inas-sirhan

packages/openapi-ts/src/__tests__/index.test.ts

@@ -413,6 +413,45 @@ describe('createClient', () => {
 
       warnSpy.mockRestore();
     });
+
+    it('does not warn when function-valued options have identical source', async () => {
+      const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
+      const transform = (s: string) => s.toUpperCase();
+
+      await createClient({
+        ...baseConfig,
+        plugins: [
+          { definitions: { name: transform }, name: '@hey-api/typescript' },
+          { definitions: { name: transform }, name: '@hey-api/typescript' },
+        ],
+      });
+
+      expect(conflictWarnings(warnSpy)).toHaveLength(0);
+
+      warnSpy.mockRestore();
+    });
+
+    it('warns when function-valued options differ', async () => {
+      const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
+
+      await createClient({
+        ...baseConfig,
+        plugins: [
+          {
+            definitions: { name: (s: string) => s.toUpperCase() },
+            name: '@hey-api/typescript',
+          },
+          {
+            definitions: { name: (s: string) => s.toLowerCase() },
+            name: '@hey-api/typescript',
+          },
+        ],
+      });
+
+      expect(conflictWarnings(warnSpy)).toHaveLength(1);
+
+      warnSpy.mockRestore();
+    });
   });
 
   it('executes @angular/common HttpRequest builder path', async () => {

packages/openapi-ts/src/config/plugins.ts

@@ -1,6 +1,6 @@
+import { log } from '@hey-api/codegen-core';
 import type { AnyPluginName, PluginContext, PluginNames } from '@hey-api/shared';
 import { dependencyFactory, valueToObject } from '@hey-api/shared';
-import colors from 'ansi-colors';
 
 import { defaultPluginConfigs } from '../plugins/config';
 import type { Config, UserConfig } from './types';
@@ -150,24 +150,27 @@ export function getPlugins({
   const seenPlugins = new Map<string, string>();
 
   const stableStringify = (value: unknown): string =>
-    JSON.stringify(value, (_, v) =>
-      v && typeof v === 'object' && !Array.isArray(v)
-        ? Object.fromEntries(
-            Object.entries(v as Record<string, unknown>).sort(([a], [b]) => a.localeCompare(b)),
-          )
-        : v,
-    );
-
-  const warnConflictingPlugin = (name: string) =>
-    console.warn(
-      `⚙️ ${colors.yellow('Warning:')} Plugin ${colors.cyan(`"${name}"`)} is configured more than once with conflicting options. Only the last occurrence will take effect.`,
-    );
+    JSON.stringify(value, (_, v) => {
+      if (typeof v === 'function') {
+        return `[function:${(v as () => unknown).toString()}]`;
+      }
+      if (v && typeof v === 'object' && !Array.isArray(v)) {
+        return Object.fromEntries(
+          Object.entries(v as Record<string, unknown>).sort(([a], [b]) =>
+            a.localeCompare(b),
+          ),
+        );
+      }
+      return v;
+    });
 
   const checkDuplicate = (name: string, config: Record<string, unknown>) => {
     const serialized = stableStringify(config);
     const previous = seenPlugins.get(name);
     if (previous !== undefined && previous !== serialized) {
-      warnConflictingPlugin(name);
+      log.warn(
+        `Plugin "${name}" is configured more than once with conflicting options. Only the last occurrence will take effect.`,
+      );
     }
     seenPlugins.set(name, serialized);
   };