Merge pull request #3454 from hey-api/copilot/fix-redundant-index-signature

fix: index signature for `additionalProperties: {}` / `true` should be `unknown`, not a union of all property types

Author: mrlubos

.changeset/plenty-brooms-reflect.md

@@ -0,0 +1,5 @@
+---
+"@hey-api/openapi-ts": patch
+---
+
+**plugin(@hey-api/typescript)**: simplify union types if a member is `unknown`

packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/additional-properties-true/types.gen.ts

@@ -6,7 +6,7 @@ export type ClientOptions = {
 
 export type Foo = {
     foo: string;
-    [key: string]: unknown | string;
+    [key: string]: unknown;
 };
 
 export type Bar = Foo & {
@@ -15,7 +15,7 @@ export type Bar = Foo & {
 
 export type Baz = Foo & {
     bar: string;
-    [key: string]: unknown | string;
+    [key: string]: unknown;
 };
 
 export type Qux = {

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/additional-properties-true/types.gen.ts

@@ -6,7 +6,7 @@ export type ClientOptions = {
 
 export type Foo = {
     foo: string;
-    [key: string]: unknown | string;
+    [key: string]: unknown;
 };
 
 export type Bar = Foo & {
@@ -15,7 +15,7 @@ export type Bar = Foo & {
 
 export type Baz = Foo & {
     bar: string;
-    [key: string]: unknown | string;
+    [key: string]: unknown;
 };
 
 export type Qux = {

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@angular/common/default-class/types.gen.ts

@@ -703,7 +703,7 @@ export type ModelWithAdditionalPropertiesEqTrue = {
      * This is a simple string property
      */
     prop?: string;
-    [key: string]: unknown | string | undefined;
+    [key: string]: unknown;
 };
 
 export type NestedAnyOfArraysNullable = {

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@angular/common/default/types.gen.ts

@@ -703,7 +703,7 @@ export type ModelWithAdditionalPropertiesEqTrue = {
      * This is a simple string property
      */
     prop?: string;
-    [key: string]: unknown | string | undefined;
+    [key: string]: unknown;
 };
 
 export type NestedAnyOfArraysNullable = {

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@hey-api/sdk/default/types.gen.ts

@@ -703,7 +703,7 @@ export type ModelWithAdditionalPropertiesEqTrue = {
      * This is a simple string property
      */
     prop?: string;
-    [key: string]: unknown | string | undefined;
+    [key: string]: unknown;
 };
 
 export type NestedAnyOfArraysNullable = {

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@hey-api/sdk/throwOnError/types.gen.ts

@@ -703,7 +703,7 @@ export type ModelWithAdditionalPropertiesEqTrue = {
      * This is a simple string property
      */
     prop?: string;
-    [key: string]: unknown | string | undefined;
+    [key: string]: unknown;
 };
 
 export type NestedAnyOfArraysNullable = {

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@pinia/colada/fetch/types.gen.ts

@@ -703,7 +703,7 @@ export type ModelWithAdditionalPropertiesEqTrue = {
      * This is a simple string property
      */
     prop?: string;
-    [key: string]: unknown | string | undefined;
+    [key: string]: unknown;
 };
 
 export type NestedAnyOfArraysNullable = {

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/angular-query-experimental/axios/types.gen.ts

@@ -703,7 +703,7 @@ export type ModelWithAdditionalPropertiesEqTrue = {
      * This is a simple string property
      */
     prop?: string;
-    [key: string]: unknown | string | undefined;
+    [key: string]: unknown;
 };
 
 export type NestedAnyOfArraysNullable = {

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/angular-query-experimental/fetch/types.gen.ts

@@ -703,7 +703,7 @@ export type ModelWithAdditionalPropertiesEqTrue = {
      * This is a simple string property
      */
     prop?: string;
-    [key: string]: unknown | string | undefined;
+    [key: string]: unknown;
 };
 
 export type NestedAnyOfArraysNullable = {