Skip to content

Commit 6dbce78

Browse files
authored
Stop rewriting Django collectstatic command log output (#1918)
Since: - The previously removed output may be useful for debugging. - Ideally output shouldn't differ from what users see locally. - Newer versions of Django are less verbose anyway. GUS-W-19780921.
1 parent 40c6272 commit 6dbce78

3 files changed

Lines changed: 7 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## [Unreleased]
44

5+
- Stopped rewriting Django collectstatic command log output. ([#1918](https://github.com/heroku/heroku-buildpack-python/pull/1918))
56
- Changed the `pip install` command used to install the pip, Pipenv and Poetry package managers to now use `--isolated` mode. ([#1915](https://github.com/heroku/heroku-buildpack-python/pull/1915))
67
- Added more Python project related file and directory names to the list recognised by buildpack detection. ([#1914](https://github.com/heroku/heroku-buildpack-python/pull/1914))
78

bin/steps/collectstatic

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export PYTHONPATH
6767
COLLECTSTATIC_LOG=$(mktemp)
6868

6969
set +e
70-
python "${MANAGE_FILE}" collectstatic --noinput --traceback |& tee "${COLLECTSTATIC_LOG}" |& sed --unbuffered '/^Post-processed/d;/^Copying/d;/^$/d' |& output::indent
70+
python "${MANAGE_FILE}" collectstatic --noinput --traceback |& tee "${COLLECTSTATIC_LOG}" |& output::indent
7171
COLLECTSTATIC_STATUS="${PIPESTATUS[0]}"
7272
set -e
7373

spec/hatchet/django_spec.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,14 @@
4747
remote: 'PWD': '/tmp/build_\\w+',
4848
remote: 'PYTHONPATH': '\\.',
4949
remote: 'PYTHONUNBUFFERED': '1'\\}
50+
remote:
5051
remote: \\['/tmp/build_\\w+/backend',
5152
remote: '/tmp/build_\\w+',
5253
remote: '/app/.heroku/python/lib/python313.zip',
5354
remote: '/app/.heroku/python/lib/python3.13',
5455
remote: '/app/.heroku/python/lib/python3.13/lib-dynload',
5556
remote: '/app/.heroku/python/lib/python3.13/site-packages'\\]
57+
remote:
5658
remote: 1 static file copied to '/tmp/build_\\w+/backend/staticfiles'.
5759
remote:
5860
remote: -----> Saving cache
@@ -86,12 +88,15 @@
8688
remote: 'PWD': '/tmp/build_\\w+',
8789
remote: 'PYTHONPATH': '/invalid-path',
8890
remote: 'PYTHONUNBUFFERED': '1'\\}
91+
remote:
8992
remote: \\['/tmp/build_\\w+',
9093
remote: '/invalid-path',
9194
remote: '/app/.heroku/python/lib/python39.zip',
9295
remote: '/app/.heroku/python/lib/python3.9',
9396
remote: '/app/.heroku/python/lib/python3.9/lib-dynload',
9497
remote: '/app/.heroku/python/lib/python3.9/site-packages'\\]
98+
remote: Copying '/tmp/build_\\w+/testapp/static/robots.txt'
99+
remote:
95100
remote: 1 static file copied to '/tmp/build_\\w+/staticfiles'.
96101
remote:
97102
remote: -----> Saving cache

0 commit comments

Comments
 (0)