Link copied feedback and some styling customisation would be sweet!

[rohan-deshpande]

Hey this is really nice.

A few suggestions

• When using the link copy button, it would be really nice to get a little bit of feedback rather than the dialog just disappearing suddenly
• It would be nice to get a styling API, right now I've had to use !important to override the styling for the UI. Let me know if there's a better way
• Just a nitpick with the component name - it's a bit odd to have the React in the name abbreviated to R, kind of non standard. I would simply change it to import { ReactWebShare } from 'react-web-share' or make it a default export.

No big deal either way, this is really helpful!

[harshzalavadiya]

@rohan-deshpande

I appreciate you taking time to provide valuable feedback

When using the link copy button, it would be really nice to get a little bit of feedback rather than the dialog just disappearing suddenly
It would be nice to get a styling API, right now I've had to use !important to override the styling for the UI. Let me know if there's a better way

Yeah, I also wanted some to add some proper UI feedback but my primary goal was to keep it minimal with zero dependency on any styling library, (Anyways I'm happy to reconsider adding some minimal styling library like https://github.com/cristianbote/goober) but this will still add 1KB(gz) to runtime which is too much for a 3KB(gz) Library

Just a nitpick with the component name - it's a bit odd to have the React in the name abbreviated to R, kind of non standard. I would simply change it to import { ReactWebShare } from 'react-web-share' or make it a default export.

I think making it default export might be better since there are no other component coming in future, I'll think of doing this in next major release

[rohan-deshpande]

Yeah, I also wanted some to add some proper UI feedback but my primary goal was to keep it minimal with zero dependency on any styling library

I think you could easily achieve this by simply

• Showing the user that the link has been copied via text in the modal
• Fading out the modal after a small period of time

You can do this without any library, it's just a bit jarring right now.

[harshzalavadiya]

@rohan-deshpande

Sounds good, If I get some time in upcoming days I'll try to incorporate this suggestions