fix: collision on lastTenant key (#3671)

* fix: collision on lastTenant key

* chore: lint

Author: abelanger5

frontend/app/src/lib/api/api.ts

@@ -48,7 +48,7 @@ export const controlPlaneApi = new ControlPlaneApi({
 api.instance.interceptors.request.use(exchangeTokenInterceptor);
 cloudApi.instance.interceptors.request.use(exchangeTokenInterceptor);
 
-export const LAST_TENANT_STORAGE_KEY = 'lastTenant';
+export const CONTROL_PLANE_TENANT_STORAGE_KEY = 'controlPlaneLastTenant';
 
 type StoredTenantLike = {
   metadata?: {
@@ -58,7 +58,7 @@ type StoredTenantLike = {
 
 function readStoredTenantId(): string | null {
   try {
-    const raw = localStorage.getItem(LAST_TENANT_STORAGE_KEY);
+    const raw = localStorage.getItem(CONTROL_PLANE_TENANT_STORAGE_KEY);
     if (!raw) {
       return null;
     }

frontend/app/src/router.tsx

@@ -7,7 +7,7 @@ import api, { TenantMember } from '@/lib/api';
 import {
   controlPlaneApi,
   fetchControlPlaneStatus,
-  LAST_TENANT_STORAGE_KEY,
+  CONTROL_PLANE_TENANT_STORAGE_KEY,
 } from '@/lib/api/api';
 import { exchangeTokenQueryOptions } from '@/lib/api/exchange-token';
 import queryClient from '@/query-client';
@@ -221,7 +221,10 @@ const tenantRoute = createRoute({
         await api.tenantGet(params.tenant, { xTenantId: params.tenant })
       ).data;
 
-      localStorage.setItem(LAST_TENANT_STORAGE_KEY, JSON.stringify(fullTenant));
+      localStorage.setItem(
+        CONTROL_PLANE_TENANT_STORAGE_KEY,
+        JSON.stringify(fullTenant),
+      );
 
       // Populate the React Query cache so pages don't re-fetch immediately.
       queryClient.setQueryData(['tenant:get', params.tenant], fullTenant);