Fixed Cart and Orders Bugs

Author: goxr3plus

app/controllers/application_controller.rb

@@ -2,11 +2,11 @@ class ApplicationController < ActionController::Base
   protect_from_forgery with: :exception
   include SessionsHelper
 
-  before_action :current_cart
+  before_action :set_cart
 
   private
 
-  def current_cart
+  def set_cart
     if session[:cart_id]
       cart = Cart.find_by(id: session[:cart_id])
       if cart.present?
@@ -17,7 +17,7 @@ def current_cart
     end
 
     if session[:cart_id].nil?
-      @current_cart = Cart.create
+      @current_cart = Cart.create(:user_id => nil)
       session[:cart_id] = @current_cart.id
     end
   end

app/controllers/carts_controller.rb

@@ -11,4 +11,11 @@ def destroy
     session[:cart_id] = nil
     redirect_to root_path
   end
+
+  private
+
+  # Never trust parameters from the scary internet, only allow the white list through.
+  def cart_params
+    params.require(:cart).permit(:user_id)
+  end
 end

app/controllers/line_items_controller.rb

@@ -2,8 +2,6 @@ class LineItemsController < ApplicationController
   before_action :logged_in_user, only: %i[create destroy add_quantity reduce_quantity]
 
   def create
-    # if(@order.nil?)
-    #   @order = Order.new(order_params)
 
     # Find associated product and current cart
     chosen_product = Product.find(params[:product_id])
@@ -19,6 +17,7 @@ def create
       @line_item = LineItem.new
       @line_item.cart = current_cart
       @line_item.product = chosen_product
+      # @line_item.order = Order.first
       @line_item.quantity = 1
     end
 

app/controllers/orders_controller.rb

@@ -23,8 +23,10 @@ def create
     @order = Order.new(order_params)
     @order.update(user_id: @current_user.id)
     @current_cart.line_items.each do |item|
-      @order.line_items << item
       item.cart_id = nil
+      item.order_id = @order.id
+      item.save
+      @order.line_items << item
     end
     @order.save!
     Cart.destroy(session[:cart_id])

app/controllers/sessions_controller.rb

@@ -11,6 +11,8 @@ def create
       if user.activated?
         log_in user
         params[:session][:remember_me] == '1' ? remember(user) : forget(user)
+
+        
         # redirect_back_or user
         redirect_back_or root_url
       else

app/models/cart.rb

@@ -1,13 +1,13 @@
 class Cart < ApplicationRecord
-  has_many :line_items, dependent: :destroy
+  has_many :line_items # , dependent: :destroy
   has_many :products, through: :line_items
 
   # LOGIC
   def sub_total
-   sum = 0
-   self.line_items.each do |line_item|
-     sum+= line_item.total_price
-   end
-   return sum
+    sum = 0
+    line_items.each do |line_item|
+      sum += line_item.total_price
+    end
+    sum
  end
 end

app/models/order.rb

@@ -1,6 +1,15 @@
 class Order < ApplicationRecord
   has_many :line_items, dependent: :destroy
 
+  # LOGIC
+  def sub_total
+    sum = 0
+    line_items.each do |line_item|
+      sum += line_item.total_price
+    end
+    sum
+  end
+
   def self.search(search)
     where('name LIKE ?', "%#{search}%")
   end

app/views/orders/_order.html.erb

@@ -21,13 +21,13 @@
 </p>
 <p>
   <h3>Total price:
-  <%= number_to_currency(@current_cart.sub_total) %></h3>
+  <%= number_to_currency(order.sub_total) %></h3>
 </p>
 
 <button type="button" class="btn btn-success" data-toggle="collapse" data-target="#<%= order.id %>">Show Items</button>
 <div id="<%= order.id %>" class="collapse">
   <ul class="users">
-    <% @current_cart.line_items.each do |item| %>
+    <% order.line_items.each do |item| %>
       <%= item.quantity %>
       x
       <%= render 'shared/order_product' , product:item.product%>

db/migrate/20180114120447_add_user_id_on_carts.rb

@@ -0,0 +1,5 @@
+class AddUserIdOnCarts < ActiveRecord::Migration[5.1]
+  def change
+    add_column :carts, :user_id, :integer
+  end
+end

db/schema.rb

@@ -10,11 +10,12 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20180109134306) do
+ActiveRecord::Schema.define(version: 20180114120447) do
 
   create_table "carts", force: :cascade do |t|
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
+    t.integer "user_id"
   end
 
   create_table "line_items", force: :cascade do |t|