refactor(view): pr-review quality fixes

- Extract REPO_STATE_TAB_IDS constant for resetViewState loops
- Export LOCKED_REPOS_CAP for test reference (no hardcoded 50)
- Fix misleading comment on migrateLockedRepos passthrough
- Reformat lock functions + moveTrackedItem to expanded style
- Replace algorithm-copy cap-guard test with integration tests
- Add custom tab lock mechanics tests for IssuesTab
- Add migrateLockedRepos mixed-type array filter test

Author: wgordon17

src/app/stores/view.ts

@@ -6,7 +6,7 @@ import { pushNotification } from "../lib/errors";
 export const VIEW_STORAGE_KEY = "github-tracker:view";
 const IGNORED_ITEMS_CAP = 500;
 const TRACKED_ITEMS_CAP = 200;
-const LOCKED_REPOS_CAP = 50;
+export const LOCKED_REPOS_CAP = 50;
 
 export const TrackedItemSchema = z.object({
   id: z.number(),
@@ -102,6 +102,8 @@ export const ViewStateSchema = z.object({
 export type ViewState = z.infer<typeof ViewStateSchema>;
 export type IgnoredItem = ViewState["ignoredItems"][number];
 
+const REPO_STATE_TAB_IDS = ["issues", "pullRequests", "actions"] as const;
+
 export function migrateLockedRepos(raw: unknown): unknown {
   if (raw == null) return { issues: [], pullRequests: [], actions: [] };
   if (Array.isArray(raw)) {
@@ -110,7 +112,7 @@ export function migrateLockedRepos(raw: unknown): unknown {
     return { issues: [...arr], pullRequests: [...arr], actions: [...arr] };
   }
   if (typeof raw === "object") {
-    // Object → pass through as-is (already per-tab record shape)
+    // Object → pass through as-is; loadViewState cap-guard sanitizes malformed entries
     return raw;
   }
   return { issues: [], pullRequests: [], actions: [] };
@@ -156,15 +158,15 @@ export function resetViewState(): void {
     produce((draft) => {
       // Delete dynamic custom tab keys that Object.assign wouldn't clear
       for (const key of Object.keys(draft.expandedRepos)) {
-        if (!["issues", "pullRequests", "actions"].includes(key)) {
+        if (!(REPO_STATE_TAB_IDS as readonly string[]).includes(key)) {
           delete draft.expandedRepos[key];
         }
       }
       for (const key of Object.keys(draft.customTabFilters)) {
         delete draft.customTabFilters[key];
       }
       for (const key of Object.keys(draft.lockedRepos)) {
-        if (!["issues", "pullRequests", "actions"].includes(key)) {
+        if (!(REPO_STATE_TAB_IDS as readonly string[]).includes(key)) {
           delete draft.lockedRepos[key];
         }
       }
@@ -371,38 +373,44 @@ export function removeCustomTabState(tabId: string): void {
 }
 
 export function lockRepo(tabKey: string, repoFullName: string): void {
-  setViewState(produce((draft) => {
-    if (!draft.lockedRepos[tabKey]) draft.lockedRepos[tabKey] = [];
-    const arr = draft.lockedRepos[tabKey];
-    if (!arr.includes(repoFullName) && arr.length < LOCKED_REPOS_CAP) {
-      arr.push(repoFullName);
-    }
-  }));
+  setViewState(
+    produce((draft) => {
+      if (!draft.lockedRepos[tabKey]) draft.lockedRepos[tabKey] = [];
+      const arr = draft.lockedRepos[tabKey];
+      if (!arr.includes(repoFullName) && arr.length < LOCKED_REPOS_CAP) {
+        arr.push(repoFullName);
+      }
+    })
+  );
 }
 
 export function unlockRepo(tabKey: string, repoFullName: string): void {
-  setViewState(produce((draft) => {
-    if (!draft.lockedRepos[tabKey]) return;
-    draft.lockedRepos[tabKey] = draft.lockedRepos[tabKey].filter(r => r !== repoFullName);
-  }));
+  setViewState(
+    produce((draft) => {
+      if (!draft.lockedRepos[tabKey]) return;
+      draft.lockedRepos[tabKey] = draft.lockedRepos[tabKey].filter((r) => r !== repoFullName);
+    })
+  );
 }
 
 export function moveLockedRepo(
   tabKey: string,
   repoFullName: string,
   direction: "up" | "down"
 ): void {
-  setViewState(produce((draft) => {
-    if (!draft.lockedRepos[tabKey]) return;
-    const arr = draft.lockedRepos[tabKey];
-    const idx = arr.indexOf(repoFullName);
-    if (idx === -1) return;
-    const targetIdx = direction === "up" ? idx - 1 : idx + 1;
-    if (targetIdx < 0 || targetIdx >= arr.length) return;
-    const tmp = arr[idx];
-    arr[idx] = arr[targetIdx];
-    arr[targetIdx] = tmp;
-  }));
+  setViewState(
+    produce((draft) => {
+      if (!draft.lockedRepos[tabKey]) return;
+      const arr = draft.lockedRepos[tabKey];
+      const idx = arr.indexOf(repoFullName);
+      if (idx === -1) return;
+      const targetIdx = direction === "up" ? idx - 1 : idx + 1;
+      if (targetIdx < 0 || targetIdx >= arr.length) return;
+      const tmp = arr[idx];
+      arr[idx] = arr[targetIdx];
+      arr[targetIdx] = tmp;
+    })
+  );
 }
 
 export function pruneLockedRepos(
@@ -412,11 +420,13 @@ export function pruneLockedRepos(
   const current = untrack(() => viewState.lockedRepos[tabKey] ?? []);
   if (current.length === 0) return;
   const activeSet = new Set(activeRepoNames);
-  const filtered = current.filter(name => activeSet.has(name));
+  const filtered = current.filter((name) => activeSet.has(name));
   if (filtered.length === current.length) return;
-  setViewState(produce((draft) => {
-    draft.lockedRepos[tabKey] = filtered;
-  }));
+  setViewState(
+    produce((draft) => {
+      draft.lockedRepos[tabKey] = filtered;
+    })
+  );
 }
 
 export function trackItem(item: TrackedItem): void {
@@ -451,16 +461,18 @@ export function moveTrackedItem(
   type: "issue" | "pullRequest",
   direction: "up" | "down"
 ): void {
-  setViewState(produce((draft) => {
-    const arr = draft.trackedItems;
-    const idx = arr.findIndex((i) => i.id === id && i.type === type);
-    if (idx === -1) return;
-    const targetIdx = direction === "up" ? idx - 1 : idx + 1;
-    if (targetIdx < 0 || targetIdx >= arr.length) return;
-    const tmp = arr[idx];
-    arr[idx] = arr[targetIdx];
-    arr[targetIdx] = tmp;
-  }));
+  setViewState(
+    produce((draft) => {
+      const arr = draft.trackedItems;
+      const idx = arr.findIndex((i) => i.id === id && i.type === type);
+      if (idx === -1) return;
+      const targetIdx = direction === "up" ? idx - 1 : idx + 1;
+      if (targetIdx < 0 || targetIdx >= arr.length) return;
+      const tmp = arr[idx];
+      arr[idx] = arr[targetIdx];
+      arr[targetIdx] = tmp;
+    })
+  );
 }
 
 export function pruneClosedTrackedItems(pruneKeys: Set<string>): void {

tests/components/dashboard/IssuesTab.test.tsx

@@ -797,6 +797,49 @@ describe("IssuesTab — empty-repo state preservation", () => {
   });
 });
 
+// ── customTabId lock mechanics ───────────────────────────────────────────────
+
+describe("IssuesTab — customTabId lock mechanics", () => {
+  it("renders stub row for a locked empty repo under a custom tab key", () => {
+    setViewState(produce((s) => {
+      s.lockedRepos["my-tab"] = ["owner/locked-empty"];
+    }));
+
+    const { container } = render(() => (
+      <IssuesTab
+        issues={[makeIssue({ id: 1, repoFullName: "owner/active-repo", surfacedBy: ["me"] })]}
+        userLogin="me"
+        customTabId="my-tab"
+        configRepoNames={["owner/active-repo", "owner/locked-empty"]}
+      />
+    ));
+
+    const stub = container.querySelector('[data-repo-group="owner/locked-empty"]');
+    expect(stub).not.toBeNull();
+    expect(stub?.textContent).toContain("owner/locked-empty");
+    expect(stub?.querySelector("[aria-expanded]")).toBeNull();
+    expect(container.querySelector('[data-repo-group="owner/active-repo"]')).not.toBeNull();
+  });
+
+  it("prunes locked repos outside configRepoNames under a custom tab key", () => {
+    setViewState(produce((s) => {
+      s.lockedRepos["my-tab"] = ["owner/kept", "owner/pruned"];
+    }));
+
+    render(() => (
+      <IssuesTab
+        issues={[makeIssue({ id: 1, repoFullName: "owner/kept", surfacedBy: ["me"] })]}
+        userLogin="me"
+        customTabId="my-tab"
+        configRepoNames={["owner/kept"]}
+      />
+    ));
+
+    expect(viewState.lockedRepos["my-tab"]).toContain("owner/kept");
+    expect(viewState.lockedRepos["my-tab"]).not.toContain("owner/pruned");
+  });
+});
+
 // ── customTabId filter preset ────────────────────────────────────────────────
 
 describe("IssuesTab — customTabId filter preset", () => {

tests/stores/view-lock.test.ts

@@ -288,6 +288,13 @@ describe("view lock store (per-tab)", () => {
       expect(migrateLockedRepos(42)).toEqual({ issues: [], pullRequests: [], actions: [] });
       expect(migrateLockedRepos("bad")).toEqual({ issues: [], pullRequests: [], actions: [] });
     });
+
+    it("filters out non-string elements from a flat mixed-type array", () => {
+      const result = migrateLockedRepos([42, "org/repo", null]) as Record<string, string[]>;
+      expect(result["issues"]).toEqual(["org/repo"]);
+      expect(result["pullRequests"]).toEqual(["org/repo"]);
+      expect(result["actions"]).toEqual(["org/repo"]);
+    });
   });
 
   describe("resetViewState — lockedRepos", () => {

tests/stores/view.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect, beforeEach, vi } from "vitest";
+import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
 import { createRoot } from "solid-js";
 import {
   viewState,
@@ -765,3 +765,46 @@ describe("expandedRepos — dynamic tab keys", () => {
     expect(viewState.expandedRepos["tab-new"]["owner/repo"]).toBe(true);
   });
 });
+
+describe("loadViewState — cap-guard integration", () => {
+  afterEach(() => {
+    localStorageMock.clear();
+  });
+
+  it("deletes non-array lockedRepos tab values and preserves valid ones", async () => {
+    localStorageMock.setItem(VIEW_KEY, JSON.stringify({
+      lastActiveTab: "actions",
+      lockedRepos: { issues: ["org/repo"], pullRequests: "bad-value" },
+    }));
+
+    vi.resetModules();
+    const mod = await import("../../src/app/stores/view");
+
+    expect(mod.viewState.lastActiveTab).toBe("actions");
+    expect(mod.viewState.lockedRepos["issues"]).toEqual(["org/repo"]);
+    expect(mod.viewState.lockedRepos["pullRequests"]).toBeUndefined();
+  });
+
+  it("truncates oversized lockedRepos arrays to LOCKED_REPOS_CAP", async () => {
+    const bigArray = Array.from({ length: 60 }, (_, i) => `org/repo-${i}`);
+    localStorageMock.setItem(VIEW_KEY, JSON.stringify({
+      lockedRepos: { issues: bigArray },
+    }));
+
+    vi.resetModules();
+    const mod = await import("../../src/app/stores/view");
+
+    expect(mod.viewState.lockedRepos["issues"].length).toBe(mod.LOCKED_REPOS_CAP);
+  });
+
+  it("filters non-string elements from lockedRepos arrays", async () => {
+    localStorageMock.setItem(VIEW_KEY, JSON.stringify({
+      lockedRepos: { issues: [42, "org/repo", null, true, "org/other"] },
+    }));
+
+    vi.resetModules();
+    const mod = await import("../../src/app/stores/view");
+
+    expect(mod.viewState.lockedRepos["issues"]).toEqual(["org/repo", "org/other"]);
+  });
+});