From 2f470a21180586a76cfbefc09ffc9915899cbfc9 Mon Sep 17 00:00:00 2001
From: Sharon Lynn <sharonlynn@google.com>
Date: Wed, 9 Sep 2026 09:01:56 +0000
Subject: [PATCH] chore(storage): remove TODOs to lift to shared bidi module

Removes TODO(#5716) header comments in bidi_write.

Bidi read and bidi write use distinct protobuf message and error types,
follow different flow control patterns, and have different stability
boundaries (read is stable, write is feature-gated). Abstracting them
into a shared module introduces unnecessary complexity for minimal reuse.
Cross-bidi refactoring can be evaluated independently from #5716.
---
 src/storage/src/storage/bidi_write/connector.rs      | 2 --
 src/storage/src/storage/bidi_write/mocks.rs          | 2 --
 src/storage/src/storage/bidi_write/redirect.rs       | 2 --
 src/storage/src/storage/bidi_write/retry_redirect.rs | 2 --
 src/storage/src/storage/bidi_write/transport.rs      | 2 --
 src/storage/src/storage/bidi_write/worker.rs         | 2 --
 6 files changed, 12 deletions(-)

diff --git a/src/storage/src/storage/bidi_write/connector.rs b/src/storage/src/storage/bidi_write/connector.rs
index 04b935e8fa..a09503284e 100644
--- a/src/storage/src/storage/bidi_write/connector.rs
+++ b/src/storage/src/storage/bidi_write/connector.rs
@@ -12,8 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// TODO(#5716): Lift to shared bidi module
-
 use super::retry_redirect::RetryRedirect;
 use super::state::AppendObjectSpecState;
 use super::{Client, TonicStreaming};
diff --git a/src/storage/src/storage/bidi_write/mocks.rs b/src/storage/src/storage/bidi_write/mocks.rs
index 9e249f8fd4..7fec9b8ce8 100644
--- a/src/storage/src/storage/bidi_write/mocks.rs
+++ b/src/storage/src/storage/bidi_write/mocks.rs
@@ -12,8 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// TODO(#5716): Lift to shared bidi module.
-
 use super::connector::Connector;
 use super::tests::test_options;
 use super::{Client, Receiver, RequestOptions, TonicStreaming};
diff --git a/src/storage/src/storage/bidi_write/redirect.rs b/src/storage/src/storage/bidi_write/redirect.rs
index 64270f9886..f2619a74ba 100644
--- a/src/storage/src/storage/bidi_write/redirect.rs
+++ b/src/storage/src/storage/bidi_write/redirect.rs
@@ -12,8 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// TODO(#5716): Lift to shared bidi module
-
 use crate::Error;
 use crate::google::rpc::Status as RpcStatus;
 use crate::google::storage::v2::BidiWriteObjectRedirectedError;
diff --git a/src/storage/src/storage/bidi_write/retry_redirect.rs b/src/storage/src/storage/bidi_write/retry_redirect.rs
index b43c307c21..43b05b35e8 100644
--- a/src/storage/src/storage/bidi_write/retry_redirect.rs
+++ b/src/storage/src/storage/bidi_write/retry_redirect.rs
@@ -12,8 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// TODO(#5716): Lift to shared bidi module
-
 use super::redirect::is_redirect;
 use google_cloud_gax::error::Error;
 use google_cloud_gax::retry_policy::RetryPolicy;
diff --git a/src/storage/src/storage/bidi_write/transport.rs b/src/storage/src/storage/bidi_write/transport.rs
index 116f1858d4..1ed9b536da 100644
--- a/src/storage/src/storage/bidi_write/transport.rs
+++ b/src/storage/src/storage/bidi_write/transport.rs
@@ -12,8 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// TODO(#5716): Lift to shared bidi module
-
 use super::coalescing_buffer::CoalescingBuffer;
 use super::connector::{Connection, Connector};
 use super::worker::{UploadIntent, Worker};
diff --git a/src/storage/src/storage/bidi_write/worker.rs b/src/storage/src/storage/bidi_write/worker.rs
index 1371bd7ee0..513c1d211c 100644
--- a/src/storage/src/storage/bidi_write/worker.rs
+++ b/src/storage/src/storage/bidi_write/worker.rs
@@ -12,8 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// TODO(#5716): Lift to shared bidi module
-
 use super::connector::Connection;
 use super::{Client, TonicStreaming};
 use crate::Error;