From cb612c2c196b3aa1234c08946d0c591093814dc3 Mon Sep 17 00:00:00 2001 From: Jon Skeet Date: Mon, 20 Apr 2026 06:53:30 +0000 Subject: [PATCH 1/3] chore: allow docs warnings in more packages Renames the post-processing file, and adds more paths to it. This file should be removed entirely once we've upgraded to a later version of the GAPIC generator which fixes the warnings. See #15475 for details on this work. --- ...ping-merchant-accounts.yaml => allow-docs-warnings.yaml} | 6 ++++++ 1 file changed, 6 insertions(+) rename .librarian/generator-input/client-post-processing/{allow-docs-warnings-for-google-shopping-merchant-accounts.yaml => allow-docs-warnings.yaml} (74%) diff --git a/.librarian/generator-input/client-post-processing/allow-docs-warnings-for-google-shopping-merchant-accounts.yaml b/.librarian/generator-input/client-post-processing/allow-docs-warnings.yaml similarity index 74% rename from .librarian/generator-input/client-post-processing/allow-docs-warnings-for-google-shopping-merchant-accounts.yaml rename to .librarian/generator-input/client-post-processing/allow-docs-warnings.yaml index 0ed1bab55e2d..01aadaef6b77 100644 --- a/.librarian/generator-input/client-post-processing/allow-docs-warnings-for-google-shopping-merchant-accounts.yaml +++ b/.librarian/generator-input/client-post-processing/allow-docs-warnings.yaml @@ -16,6 +16,12 @@ url: https://github.com/googleapis/gapic-generator-python/issues/2490 replacements: - paths: [ packages/google-shopping-merchant-accounts/noxfile.py, + packages/google-cloud-compute/noxfile.py, + packages/google-cloud-compute-v1beta/noxfile.py, + packages/google-cloud-container/noxfile.py, + packages/google-cloud-dataplex/noxfile.py, + packages/google-cloud-network-connectivity/noxfile.py, + packages/google-cloud-recaptcha-enterprise/noxfile.py, ] before: ' "-W", # warnings as errors\n' after: '' From a40092de4143f1b3a8b5369f06a9923b32761b96 Mon Sep 17 00:00:00 2001 From: Jon Skeet Date: Mon, 20 Apr 2026 07:08:06 +0000 Subject: [PATCH 2/3] chore: add dialogflow-cx and sort --- .../client-post-processing/allow-docs-warnings.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.librarian/generator-input/client-post-processing/allow-docs-warnings.yaml b/.librarian/generator-input/client-post-processing/allow-docs-warnings.yaml index 01aadaef6b77..d610f0c2f225 100644 --- a/.librarian/generator-input/client-post-processing/allow-docs-warnings.yaml +++ b/.librarian/generator-input/client-post-processing/allow-docs-warnings.yaml @@ -15,13 +15,14 @@ description: Allow documentation warnings for google-shopping-merchant-accounts url: https://github.com/googleapis/gapic-generator-python/issues/2490 replacements: - paths: [ - packages/google-shopping-merchant-accounts/noxfile.py, packages/google-cloud-compute/noxfile.py, packages/google-cloud-compute-v1beta/noxfile.py, packages/google-cloud-container/noxfile.py, packages/google-cloud-dataplex/noxfile.py, + packages/google-cloud-dialogflow-cx/noxfile.py, packages/google-cloud-network-connectivity/noxfile.py, packages/google-cloud-recaptcha-enterprise/noxfile.py, + packages/google-shopping-merchant-accounts/noxfile.py, ] before: ' "-W", # warnings as errors\n' after: '' From cc2802fda3e7607aaafd089bb02b098ed1c8e52f Mon Sep 17 00:00:00 2001 From: Jon Skeet Date: Mon, 20 Apr 2026 07:13:40 +0000 Subject: [PATCH 3/3] chore: split replacements into one entry per package --- .../allow-docs-warnings.yaml | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/.librarian/generator-input/client-post-processing/allow-docs-warnings.yaml b/.librarian/generator-input/client-post-processing/allow-docs-warnings.yaml index d610f0c2f225..60fb84dca2ed 100644 --- a/.librarian/generator-input/client-post-processing/allow-docs-warnings.yaml +++ b/.librarian/generator-input/client-post-processing/allow-docs-warnings.yaml @@ -13,15 +13,53 @@ # limitations under the License. description: Allow documentation warnings for google-shopping-merchant-accounts due to formatting issue in google/protobuf/empty.proto url: https://github.com/googleapis/gapic-generator-python/issues/2490 +# Note: having one replacement per package instead of just listing the paths +# is annoying, but that's what synthtool expects and it's not worth fixing that +# at this stage. replacements: - paths: [ packages/google-cloud-compute/noxfile.py, + ] + before: ' "-W", # warnings as errors\n' + after: '' + count: 1 + - paths: [ packages/google-cloud-compute-v1beta/noxfile.py, + ] + before: ' "-W", # warnings as errors\n' + after: '' + count: 1 + - paths: [ packages/google-cloud-container/noxfile.py, + ] + before: ' "-W", # warnings as errors\n' + after: '' + count: 1 + - paths: [ packages/google-cloud-dataplex/noxfile.py, + ] + before: ' "-W", # warnings as errors\n' + after: '' + count: 1 + - paths: [ packages/google-cloud-dialogflow-cx/noxfile.py, + ] + before: ' "-W", # warnings as errors\n' + after: '' + count: 1 + - paths: [ packages/google-cloud-network-connectivity/noxfile.py, + ] + before: ' "-W", # warnings as errors\n' + after: '' + count: 1 + - paths: [ packages/google-cloud-recaptcha-enterprise/noxfile.py, + ] + before: ' "-W", # warnings as errors\n' + after: '' + count: 1 + - paths: [ packages/google-shopping-merchant-accounts/noxfile.py, ] before: ' "-W", # warnings as errors\n'