Repository navigation
Commit cf211ea
authored
fix(gax-httpjson): use Conscrypt TrustManagerFactory for mTLS SSLContext (#14556)
> [!IMPORTANT]
> **This must merge before the `agentic-identities-bound-token` feature
branch is merged to `main`.** Without it, HTTP/JSON clients fail by
default wherever mTLS is enabled automatically (see below).
## Problem
When mTLS is active,
`InstantiatingHttpJsonChannelProvider.configureMtls()` builds a
Conscrypt `SSLContext` but initializes it with the JDK (SunJSSE) PKIX
`TrustManagerFactory`. On TLS 1.3, Conscrypt passes authType `"GENERIC"`
to the trust manager. SunJSSE's end-entity checks reject that authType
for server certificates that are CA-issued and carry a KeyUsage
extension, which includes Google front ends. So every mTLS HTTP/JSON
handshake fails with:
```
javax.net.ssl.SSLHandshakeException: Unknown authType: GENERIC
Caused by: java.security.cert.CertificateException: Unknown authType: GENERIC
```
The bug is already on `main`, but there it only triggers when
`GOOGLE_API_USE_CLIENT_CERTIFICATE=true` is set explicitly. On this
feature branch, #13995 enables mTLS automatically whenever a workload
certificate config is present, so on Cloud Run (agent identity) **every
HTTP/JSON client fails by default**. gRPC isn't affected. The non-mTLS
path isn't affected either, because google-http-client already pairs
Conscrypt with a provider-matched trust manager there.
A second provider mismatch shows up on JDK 26: the mTLS `SSLContext`
also used the JDK's default (`SunX509`) `KeyManagerFactory`. Since JDK
26 ([JDK-8359956](https://bugs.openjdk.org/browse/JDK-8359956)), that
key manager applies algorithm constraints to the client certificate.
Called from a Conscrypt handshake, it rejects valid certificates (e.g.
`SHA256withRSA`), so the client sends an empty certificate chain and the
server aborts with `certificate_required`.
## Fix
Use Conscrypt's own PKIX `TrustManagerFactory`
(`TrustManagerFactory.getInstance("PKIX", conscryptProvider)`) for the
mTLS `SSLContext`. I called the JDK API directly rather than
`SslUtils.getPkixTrustManagerFactory(Provider)`, which only exists in
google-http-client 2.2.0+.
Likewise, use Conscrypt's own `KeyManagerFactory`
(`KeyManagerFactory.getInstance("PKIX", conscryptProvider)`), so the
trust manager and key manager both come from the same provider as the
`SSLContext`.
Conscrypt's trust manager loads the same default trust store as the JDK.
Verified on JDK 21: 174 anchors in both, the same set, and both honor
`-Djavax.net.ssl.trustStore` overrides identically.
## Testing
- New `InstantiatingHttpJsonChannelProviderTls13Test`: a local JDK TLS
1.3 server presents a CA-issued leaf with KeyUsage and requires a client
certificate. The test asserts that the transport completes the request
and presents its client certificate.
- Without the fix: fails with `Unknown authType: GENERIC`.
- With the fix: passes.
- Skips when Conscrypt native or TLS 1.3 is unavailable.
- Full `gax-httpjson` suite on the current
`agentic-identities-bound-token` (with #13995 merged): 194/194 pass on
JDK 8, 11, 17, 21, 25 and 26. On JDK 26, the Tls13 test fails without
the `KeyManagerFactory` change: the client sends an empty certificate
chain and times out.
- End-to-end with #13995's certificate-rotation support, on JDK 21 with
Conscrypt active: 22 scenarios with real KMS and BigQuery Storage GAPIC
clients against local mTLS servers, where the certificate rotates on
disk.
- With this fix: all 22 pass. That includes HTTP/JSON rotation,
in-flight calls during refresh, and stress with `close()`. The refreshed
transport still uses Conscrypt's socket factory.
- Without this fix: every HTTP/JSON mTLS scenario fails with `Unknown
authType: GENERIC`. Limiting the test server to TLS 1.2 makes the error
go away, which confirms that the TLS 1.3 authType is the trigger.
- Logs: https://paste.googleplex.com/5563956459077632 (with fix),
https://paste.googleplex.com/5467233782988800 (without fix, JDK 21 set)
- Live on Cloud Run (agent identity), combined #13873 + #13995 build,
default env:
| | gRPC | HTTP/JSON |
|---|---|---|
| Before | ✅ | ❌ `Unknown authType: GENERIC` |
| After | ✅ | ✅ authenticated over mTLS with a bound token |1 parent 6f8311e commit cf211ea
5 files changed
Lines changed: 368 additions & 6 deletions
File tree
- sdk-platform-java/gax-java/gax-httpjson
- src
- main/java/com/google/api/gax/httpjson
- test
- java/com/google/api/gax/httpjson
- resources/com/google/api/gax/httpjson
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
56 | 60 | | |
57 | 61 | | |
58 | 62 | | |
| |||
Lines changed: 18 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
56 | 57 | | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
218 | 220 | | |
219 | 221 | | |
220 | 222 | | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
225 | 228 | | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
226 | 238 | | |
227 | 239 | | |
228 | 240 | | |
229 | | - | |
| 241 | + | |
230 | 242 | | |
231 | 243 | | |
232 | | - | |
| 244 | + | |
233 | 245 | | |
234 | 246 | | |
235 | 247 | | |
| |||
Lines changed: 279 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
Lines changed: 19 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
0 commit comments