Repository navigation
Commit 8b9072e
committed
fix(auth): defer certificate-bound ID tokens; bind access tokens only (#13873)
For the initial launch, only access tokens are certificate-bound for agent
identities. ComputeEngineCredentials.idTokenWithAudience() goes back to a
plain GET of the identity endpoint: no certificate_chain POST body, no forced
format=full, and no bound-token-specific 404 message. This matches Google
Auth Library for Python, which binds access tokens but not ID tokens.
refreshAccessToken() is unchanged and still requests bound access tokens.
Tests: the ID-token cases in ComputeEngineCredentialsTest now assert that,
with an agent identity certificate present and binding enabled, ID tokens are
requested unbound, and that a 404 produces the standard ID-token error.1 parent f17f773 commit 8b9072e
2 files changed
Lines changed: 15 additions & 29 deletions
File tree
- google-auth-library-java/oauth2_http
- javatests/com/google/auth/oauth2
- java/com/google/auth/oauth2
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
494 | 494 | | |
495 | 495 | | |
496 | 496 | | |
497 | | - | |
| 497 | + | |
| 498 | + | |
498 | 499 | | |
499 | | - | |
500 | | - | |
501 | | - | |
502 | 500 | | |
503 | 501 | | |
504 | 502 | | |
| |||
511 | 509 | | |
512 | 510 | | |
513 | 511 | | |
514 | | - | |
515 | | - | |
| 512 | + | |
| 513 | + | |
516 | 514 | | |
517 | 515 | | |
518 | | - | |
519 | | - | |
520 | | - | |
521 | | - | |
522 | | - | |
523 | | - | |
524 | | - | |
525 | | - | |
526 | 516 | | |
527 | 517 | | |
528 | 518 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1360 | 1360 | | |
1361 | 1361 | | |
1362 | 1362 | | |
1363 | | - | |
| 1363 | + | |
| 1364 | + | |
| 1365 | + | |
| 1366 | + | |
1364 | 1367 | | |
1365 | | - | |
1366 | | - | |
| 1368 | + | |
1367 | 1369 | | |
1368 | 1370 | | |
1369 | 1371 | | |
| |||
1374 | 1376 | | |
1375 | 1377 | | |
1376 | 1378 | | |
1377 | | - | |
1378 | | - | |
| 1379 | + | |
1379 | 1380 | | |
1380 | | - | |
1381 | | - | |
1382 | | - | |
1383 | | - | |
1384 | | - | |
1385 | | - | |
1386 | | - | |
| 1381 | + | |
| 1382 | + | |
1387 | 1383 | | |
1388 | 1384 | | |
1389 | 1385 | | |
| |||
1401 | 1397 | | |
1402 | 1398 | | |
1403 | 1399 | | |
1404 | | - | |
1405 | | - | |
| 1400 | + | |
1406 | 1401 | | |
1407 | 1402 | | |
1408 | 1403 | | |
| |||
1413 | 1408 | | |
1414 | 1409 | | |
1415 | 1410 | | |
1416 | | - | |
| 1411 | + | |
| 1412 | + | |
1417 | 1413 | | |
1418 | 1414 | | |
1419 | 1415 | | |
| |||
0 commit comments