fix: address Copilot review comments on hook invocation consistency

- Add is_slash_skills_agent() helper to extensions.py to centralize the
  agent-to-invocation-format mapping, reducing drift risk between
  HookExecutor._render_hook_invocation() and init.py _display_cmd()
- Use the shared helper in both locations; init.py now imports and
  delegates to is_slash_skills_agent() instead of maintaining its own
  per-agent boolean matrix
- Fix test_hooks_render_skill_invocation to use ai_skills=False,
  proving Zed renders /speckit-<name> unconditionally
- Add parameterized TestSlashSkillsSets covering all agents in
  ALWAYS_SLASH_AGENTS and CONDITIONAL_SLASH_AGENTS with ai_skills
  both true and false

Author: arrrrny

src/specify_cli/commands/init.py

@@ -738,20 +738,15 @@ def init(
             step_num += 1
         usage_label = "skills" if native_skill_mode else "slash commands"
 
+        from ..extensions import is_slash_skills_agent as _is_slash_skills_agent
+
         def _display_cmd(name: str) -> str:
             if codex_skill_mode:
                 return f"$speckit-{name}"
-            if claude_skill_mode:
-                return f"/speckit-{name}"
             if kimi_skill_mode:
                 return f"/skill:speckit-{name}"
             if (
-                agy_skill_mode
-                or trae_skill_mode
-                or cursor_agent_skill_mode
-                or copilot_skill_mode
-                or devin_skill_mode
-                or zed_skill_mode
+                _is_slash_skills_agent(selected_ai, _is_skills_integration)
                 or cline_skill_mode
             ):
                 return f"/speckit-{name}"

src/specify_cli/extensions.py

@@ -51,6 +51,22 @@
 )
 EXTENSION_COMMAND_NAME_PATTERN = re.compile(r"^speckit\.([a-z0-9-]+)\.([a-z0-9-]+)$")
 
+
+def is_slash_skills_agent(selected_ai: str, ai_skills_enabled: bool) -> bool:
+    """Return True if *selected_ai* uses ``/speckit-<name>`` hook invocations.
+
+    The decision is based on the agent sets defined above:
+
+    *   Agents in `ALWAYS_SLASH_AGENTS` always use slash invocations.
+    *   Agents in `CONDITIONAL_SLASH_AGENTS` only use them when
+        *ai_skills_enabled* is ``True``.
+    *   All other agents return ``False``.
+    """
+    return selected_ai in ALWAYS_SLASH_AGENTS or (
+        selected_ai in CONDITIONAL_SLASH_AGENTS and ai_skills_enabled
+    )
+
+
 DEFAULT_HOOK_PRIORITY = 10
 
 REINSTALL_COMMAND = "uv tool install specify-cli --force --from git+https://github.com/github/spec-kit.git"
@@ -2807,12 +2823,7 @@ def _render_hook_invocation(self, command: Any) -> str:
 
             return f"/{format_cline_command_name(command_id)}"
 
-        # Agents that use /speckit-<name> (slash-skills invocation):
-        # - Always skills-based: devin, trae, zed
-        # - Conditional on ai_skills: agy, claude, copilot, cursor-agent
-        use_slash = selected_ai in ALWAYS_SLASH_AGENTS or (
-            selected_ai in CONDITIONAL_SLASH_AGENTS and ai_skills_enabled
-        )
+        use_slash = is_slash_skills_agent(selected_ai, ai_skills_enabled)
 
         if skill_name and use_slash:
             return f"/{skill_name}"

tests/integrations/test_integration_zed.py

@@ -2,6 +2,8 @@
 
 import json
 
+import pytest
+
 from specify_cli.integrations import get_integration
 
 from .test_integration_base_skills import SkillsIntegrationTests
@@ -34,13 +36,14 @@ class TestZedHookInvocations:
     """Zed hook messages should reference slash-invokable skills."""
 
     def test_hooks_render_skill_invocation(self, tmp_path):
+        """Zed is always skills-based: renders /speckit-plan even with ai_skills=False."""
         from specify_cli.extensions import HookExecutor
 
         project = tmp_path / "zed-hooks"
         project.mkdir()
         init_options = project / ".specify" / "init-options.json"
         init_options.parent.mkdir(parents=True, exist_ok=True)
-        init_options.write_text(json.dumps({"ai": "zed", "ai_skills": True}))
+        init_options.write_text(json.dumps({"ai": "zed", "ai_skills": False}))
 
         hook_executor = HookExecutor(project)
         message = hook_executor.format_hook_message(
@@ -54,8 +57,6 @@ def test_hooks_render_skill_invocation(self, tmp_path):
             ],
         )
 
-        assert "Executing: `/speckit-plan`" in message
-        assert "EXECUTE_COMMAND: speckit.plan" in message
         assert "EXECUTE_COMMAND_INVOCATION: /speckit-plan" in message
 
     def test_init_persists_ai_skills_for_zed(self, tmp_path, monkeypatch):
@@ -107,7 +108,48 @@ def test_init_persists_ai_skills_for_zed(self, tmp_path, monkeypatch):
             ],
         )
         assert "Executing: `/speckit-plan`" in message, (
-            "Hook rendering must produce /speckit-plan for Zed without hint injection\n"
-            f"Got message: {message}"
+            "Hook rendering must produce /speckit-plan for Zed without hint injection"
         )
         assert "EXECUTE_COMMAND_INVOCATION: /speckit-plan" in message
+
+
+class TestSlashSkillsSets:
+    """Parameterized coverage for ALWAYS_SLASH_AGENTS / CONDITIONAL_SLASH_AGENTS."""
+
+    @staticmethod
+    def _render_invocation(project_path, ai: str, ai_skills: bool) -> str:
+        """Return the rendered invocation for ``speckit.plan`` via HookExecutor."""
+        from specify_cli.extensions import HookExecutor
+
+        init_options = project_path / ".specify" / "init-options.json"
+        init_options.parent.mkdir(parents=True, exist_ok=True)
+        init_options.write_text(json.dumps({"ai": ai, "ai_skills": ai_skills}))
+        hook_executor = HookExecutor(project_path)
+        return hook_executor._render_hook_invocation("speckit.plan")
+
+    @pytest.mark.parametrize(
+        ("ai", "ai_skills", "expected"),
+        [
+            # ALWAYS_SLASH_AGENTS — unconditional on ai_skills
+            ("devin", True, "/speckit-plan"),
+            ("devin", False, "/speckit-plan"),
+            ("trae", True, "/speckit-plan"),
+            ("trae", False, "/speckit-plan"),
+            ("zed", True, "/speckit-plan"),
+            ("zed", False, "/speckit-plan"),
+            # CONDITIONAL_SLASH_AGENTS — only when ai_skills is enabled
+            ("agy", True, "/speckit-plan"),
+            ("agy", False, "/speckit.plan"),
+            ("claude", True, "/speckit-plan"),
+            ("claude", False, "/speckit.plan"),
+            ("copilot", True, "/speckit-plan"),
+            ("copilot", False, "/speckit.plan"),
+            ("cursor-agent", True, "/speckit-plan"),
+            ("cursor-agent", False, "/speckit.plan"),
+        ],
+    )
+    def test_hook_invocation_format(self, tmp_path, ai, ai_skills, expected):
+        result = self._render_invocation(tmp_path, ai, ai_skills)
+        assert result == expected, (
+            f"{ai} (ai_skills={ai_skills}): expected {expected!r}, got {result!r}"
+        )