fix: move defaulted 'state' param after non-default params in list_code_scanning_alerts

ph3t · web-flow · commit da9c97bcf193 · 2025-06-06T15:40:21.000+02:00
Fixes `SyntaxError: parameter without a default follows parameter with a default` when using github-mcp-server with the Python MCP SDK
diff --git a/pkg/github/code_scanning.go b/pkg/github/code_scanning.go
@@ -115,11 +115,11 @@ func ListCodeScanningAlerts(getClient GetClientFn, t translations.TranslationHel
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
-			ref, err := OptionalParam[string](request, "ref")
+			state, err := OptionalParam[string](request, "state")
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
-			state, err := OptionalParam[string](request, "state")
+			ref, err := OptionalParam[string](request, "ref")
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}

Original file line number	Diff line number	Diff line change
`@@ -115,11 +115,11 @@ func ListCodeScanningAlerts(getClient GetClientFn, t translations.TranslationHel`
`115`	`115`	`if err != nil {`
`116`	`116`	`return mcp.NewToolResultError(err.Error()), nil`
`117`	`117`	`}`
`118`		`- ref, err := OptionalParam[string](request, "ref")`
	`118`	`+ state, err := OptionalParam[string](request, "state")`
`119`	`119`	`if err != nil {`
`120`	`120`	`return mcp.NewToolResultError(err.Error()), nil`
`121`	`121`	`}`
`122`		`- state, err := OptionalParam[string](request, "state")`
	`122`	`+ ref, err := OptionalParam[string](request, "ref")`
`123`	`123`	`if err != nil {`
`124`	`124`	`return mcp.NewToolResultError(err.Error()), nil`
`125`	`125`	`}`