Skip to content

Commit 808697e

Browse files
SamMorrowDrumsSamMorrowDrums
committed
test: cover direct Markdown fidelity responses
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 69c5ab30-9815-4c07-8385-11a206e68f66
1 parent 89b787e commit 808697e

3 files changed

Lines changed: 26 additions & 19 deletions

File tree

‎pkg/github/find_duplicate_test.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ func Test_FindDuplicate_SanitizesIssueTitle(t *testing.T) {
165165
require.NoError(t, json.Unmarshal([]byte(text.Text), &candidates))
166166
require.Len(t, candidates, 1)
167167
assert.Equal(t, sanitizedText, candidates[0].Issue.Title)
168-
assert.NotContains(t, text.Text, "<script>")
169168
}
170169

171170
func Test_FindDuplicate_OmitsUnsetParams(t *testing.T) {

‎pkg/github/issues_test.go‎

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5774,8 +5774,8 @@ func Test_AddSubIssue(t *testing.T) {
57745774
// Setup mock issue for success case (matches GitHub API response format)
57755775
mockIssue := &github.Issue{
57765776
Number: github.Ptr(42),
5777-
Title: github.Ptr("Parent Issue"),
5778-
Body: github.Ptr("This is the parent issue with a sub-issue"),
5777+
Title: github.Ptr("<int>\u200B"),
5778+
Body: github.Ptr("This is **Markdown**\u200B"),
57795779
State: github.Ptr("open"),
57805780
HTMLURL: github.Ptr("https://github.com/owner/repo/issues/42"),
57815781
User: &github.User{
@@ -5970,8 +5970,8 @@ func Test_AddSubIssue(t *testing.T) {
59705970
err = json.Unmarshal([]byte(textContent.Text), &returnedIssue)
59715971
require.NoError(t, err)
59725972
assert.Equal(t, *tc.expectedIssue.Number, *returnedIssue.Number)
5973-
assert.Equal(t, *tc.expectedIssue.Title, *returnedIssue.Title)
5974-
assert.Equal(t, *tc.expectedIssue.Body, *returnedIssue.Body)
5973+
assert.Empty(t, *returnedIssue.Title)
5974+
assert.Equal(t, "This is **Markdown**", *returnedIssue.Body)
59755975
assert.Equal(t, *tc.expectedIssue.State, *returnedIssue.State)
59765976
assert.Equal(t, *tc.expectedIssue.HTMLURL, *returnedIssue.HTMLURL)
59775977
assert.Equal(t, *tc.expectedIssue.User.Login, *returnedIssue.User.Login)
@@ -5999,8 +5999,8 @@ func Test_GetSubIssues(t *testing.T) {
59995999
mockSubIssues := []*github.Issue{
60006000
{
60016001
Number: github.Ptr(123),
6002-
Title: github.Ptr("Sub-issue 1"),
6003-
Body: github.Ptr("This is the first sub-issue"),
6002+
Title: github.Ptr("<int>\u200B"),
6003+
Body: github.Ptr("This is **Markdown**\u200B"),
60046004
State: github.Ptr("open"),
60056005
HTMLURL: github.Ptr("https://github.com/owner/repo/issues/123"),
60066006
User: &github.User{
@@ -6199,12 +6199,17 @@ func Test_GetSubIssues(t *testing.T) {
61996199
for i, subIssue := range returnedSubIssues {
62006200
if i < len(tc.expectedSubIssues) {
62016201
assert.Equal(t, *tc.expectedSubIssues[i].Number, *subIssue.Number)
6202-
assert.Equal(t, *tc.expectedSubIssues[i].Title, *subIssue.Title)
6202+
if i == 0 {
6203+
assert.Empty(t, *subIssue.Title)
6204+
assert.Equal(t, "This is **Markdown**", *subIssue.Body)
6205+
} else {
6206+
assert.Equal(t, *tc.expectedSubIssues[i].Title, *subIssue.Title)
6207+
}
62036208
assert.Equal(t, *tc.expectedSubIssues[i].State, *subIssue.State)
62046209
assert.Equal(t, *tc.expectedSubIssues[i].HTMLURL, *subIssue.HTMLURL)
62056210
assert.Equal(t, *tc.expectedSubIssues[i].User.Login, *subIssue.User.Login)
62066211

6207-
if tc.expectedSubIssues[i].Body != nil {
6212+
if i != 0 && tc.expectedSubIssues[i].Body != nil {
62086213
assert.Equal(t, *tc.expectedSubIssues[i].Body, *subIssue.Body)
62096214
}
62106215
}
@@ -6652,8 +6657,8 @@ func Test_RemoveSubIssue(t *testing.T) {
66526657
// Setup mock issue for success case (matches GitHub API response format - the updated parent issue)
66536658
mockIssue := &github.Issue{
66546659
Number: github.Ptr(42),
6655-
Title: github.Ptr("Parent Issue"),
6656-
Body: github.Ptr("This is the parent issue after sub-issue removal"),
6660+
Title: github.Ptr("<int>\u200B"),
6661+
Body: github.Ptr("This is **Markdown**\u200B"),
66576662
State: github.Ptr("open"),
66586663
HTMLURL: github.Ptr("https://github.com/owner/repo/issues/42"),
66596664
User: &github.User{
@@ -6831,8 +6836,8 @@ func Test_RemoveSubIssue(t *testing.T) {
68316836
err = json.Unmarshal([]byte(textContent.Text), &returnedIssue)
68326837
require.NoError(t, err)
68336838
assert.Equal(t, *tc.expectedIssue.Number, *returnedIssue.Number)
6834-
assert.Equal(t, *tc.expectedIssue.Title, *returnedIssue.Title)
6835-
assert.Equal(t, *tc.expectedIssue.Body, *returnedIssue.Body)
6839+
assert.Empty(t, *returnedIssue.Title)
6840+
assert.Equal(t, "This is **Markdown**", *returnedIssue.Body)
68366841
assert.Equal(t, *tc.expectedIssue.State, *returnedIssue.State)
68376842
assert.Equal(t, *tc.expectedIssue.HTMLURL, *returnedIssue.HTMLURL)
68386843
assert.Equal(t, *tc.expectedIssue.User.Login, *returnedIssue.User.Login)
@@ -6860,8 +6865,8 @@ func Test_ReprioritizeSubIssue(t *testing.T) {
68606865
// Setup mock issue for success case (matches GitHub API response format - the updated parent issue)
68616866
mockIssue := &github.Issue{
68626867
Number: github.Ptr(42),
6863-
Title: github.Ptr("Parent Issue"),
6864-
Body: github.Ptr("This is the parent issue with reprioritized sub-issues"),
6868+
Title: github.Ptr("<int>\u200B"),
6869+
Body: github.Ptr("This is **Markdown**\u200B"),
68656870
State: github.Ptr("open"),
68666871
HTMLURL: github.Ptr("https://github.com/owner/repo/issues/42"),
68676872
User: &github.User{
@@ -7091,8 +7096,8 @@ func Test_ReprioritizeSubIssue(t *testing.T) {
70917096
err = json.Unmarshal([]byte(textContent.Text), &returnedIssue)
70927097
require.NoError(t, err)
70937098
assert.Equal(t, *tc.expectedIssue.Number, *returnedIssue.Number)
7094-
assert.Equal(t, *tc.expectedIssue.Title, *returnedIssue.Title)
7095-
assert.Equal(t, *tc.expectedIssue.Body, *returnedIssue.Body)
7099+
assert.Empty(t, *returnedIssue.Title)
7100+
assert.Equal(t, "This is **Markdown**", *returnedIssue.Body)
70967101
assert.Equal(t, *tc.expectedIssue.State, *returnedIssue.State)
70977102
assert.Equal(t, *tc.expectedIssue.HTMLURL, *returnedIssue.HTMLURL)
70987103
assert.Equal(t, *tc.expectedIssue.User.Login, *returnedIssue.User.Login)

‎pkg/github/repositories_test.go‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4855,6 +4855,7 @@ func Test_GetLatestRelease(t *testing.T) {
48554855
ID: 1,
48564856
TagName: "v1.0.0",
48574857
Name: github.Ptr("First Release"),
4858+
Body: github.Ptr("<details>Notes</details>\u200B"),
48584859
}
48594860

48604861
tests := []struct {
@@ -4922,6 +4923,8 @@ func Test_GetLatestRelease(t *testing.T) {
49224923
err = json.Unmarshal([]byte(textContent.Text), &returnedRelease)
49234924
require.NoError(t, err)
49244925
assert.Equal(t, tc.expectedResult.TagName, returnedRelease.TagName)
4926+
assert.Equal(t, "First Release", *returnedRelease.Name)
4927+
assert.Equal(t, "<details>Notes</details>", *returnedRelease.Body)
49254928
})
49264929
}
49274930
}
@@ -4945,7 +4948,7 @@ func Test_GetReleaseByTag(t *testing.T) {
49454948
ID: 1,
49464949
TagName: "v1.0.0",
49474950
Name: github.Ptr("Release v1.0.0"),
4948-
Body: github.Ptr("This is the first stable release."),
4951+
Body: github.Ptr("<details>Notes</details>\u200B"),
49494952
Assets: []*github.ReleaseAsset{
49504953
{
49514954
ID: github.Ptr(int64(1)),
@@ -5087,7 +5090,7 @@ func Test_GetReleaseByTag(t *testing.T) {
50875090
assert.Equal(t, tc.expectedResult.TagName, returnedRelease.TagName)
50885091
assert.Equal(t, *tc.expectedResult.Name, *returnedRelease.Name)
50895092
if tc.expectedResult.Body != nil {
5090-
assert.Equal(t, *tc.expectedResult.Body, *returnedRelease.Body)
5093+
assert.Equal(t, "<details>Notes</details>", *returnedRelease.Body)
50915094
}
50925095
if len(tc.expectedResult.Assets) > 0 {
50935096
require.Len(t, returnedRelease.Assets, len(tc.expectedResult.Assets))

0 commit comments

Comments
 (0)