Rebase on partial merge shouldn't automatically dismiss approvals #460
aleksei-averchenko-wise
started this conversation in
Feedback
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Automatic rebase on partial stack merge shouldn't automatically dismiss approvals, at least when the reviewable diff remains the same. It's a major usability gap, as illustrated by the following example:
main -> A ✅ -> B ✅ -> C ✅- all approved.A.main -> A (merged) -> B ⌧ -> C ⌧- my approvals onBandCare gone, and it might take hours for the code reviewers to re-stamp them.All reactions