Commit 318a6d4
Add sandbox-less mode with
* Initial plan
* Planning sandbox-less mode implementation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
* Phase 1 complete: Parsing and validation for sandbox: false
- Updated JSON schema to allow boolean values for sandbox field
- Modified extractSandboxConfig to handle sandbox: false
- Updated validation to only refuse in strict mode (not in non-strict mode)
- Added compile-time warning when sandbox: false is used
- Added helper function isSandboxDisabled()
- Updated applySandboxDefaults to preserve disabled state
- Updated buildMCPGatewayConfig to return nil when sandbox disabled
Next: Need to skip gateway startup step generation when sandbox disabled
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
* Phase 2: Skip MCP gateway step generation when sandbox disabled
- Added conditional check to skip "Start MCP gateway" step when sandbox: false
- Gateway config is already nil when sandbox disabled (from Phase 1)
- MCP config is still generated but without gateway section
- Tests show good progress - no gateway step being generated
- Still need to skip gateway Docker image download
- Still need to skip gateway stop step
Next: Complete gateway-related step cleanup and fix remaining integration tests
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
* Complete sandbox-less mode cleanup: skip gateway steps and Docker images
- Skip MCP gateway Docker image download when sandbox: false
- Skip "Stop MCP gateway" step generation when sandbox: false
- Skip "Parse MCP gateway logs" step generation when sandbox: false
- All sandbox disabled tests passing
- Verified compiled workflows have no gateway references or environment variables
Addresses feedback: https://github.com/githubnext/gh-aw/pull/XXX#issuecomment-3739970970
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
* Add daily-team-evolution-insights workflow using sandbox: false
Created a new agentic workflow that demonstrates sandbox-less mode:
- Uses Claude engine with sandbox: false
- Analyzes last 24 hours of repository activity
- Extracts insights about team evolution and working patterns
- Posts findings as a GitHub Discussion
- Direct MCP server access without gateway
- Network access without firewall restrictions
The workflow showcases practical use of sandbox: false for trusted
analysis tasks where the overhead of gateway/firewall isn't needed.
Verified compilation:
- No "Start MCP gateway" step
- No "Stop MCP gateway" step
- No MCP_GATEWAY_* environment variables
- firewall_enabled: false in metadata
- Warning displayed about disabled security protections
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
* Update dev.md to use sandbox: false
Changed dev.md workflow to demonstrate sandbox-less mode:
- Set sandbox: false to disable firewall and gateway
- Changed strict: true to strict: false (required for sandbox: false)
- Added network.allowed: ["*"] for unrestricted access
- Workflow now runs with direct MCP server access
Verified compilation:
- No "Start MCP gateway" step
- No "Stop MCP gateway" step
- No MCP_GATEWAY_* environment variables
- firewall_enabled: false in metadata
- Warning displayed about disabled security protections
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
* Run format and lint: fix formatting issues
Ran make fmt, make lint, and make lint-cjs:
- Fixed JSON schema formatting (arrays on single lines)
- Removed trailing whitespace in docker.go
- Fixed indentation in mcp_servers.go
- Fixed indentation in sandbox_disabled_test.go
All linters passing:
- Go linter: ✓ 0 issues
- JavaScript linter: ✓ All files use Prettier code style
- All validations passed
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>sandbox: false configuration (#9758)1 parent 3090d2a commit 318a6d4
14 files changed
Lines changed: 2082 additions & 262 deletions
File tree
- .github/workflows
- pkg
- parser/schemas
- workflow
Lines changed: 1214 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
0 commit comments