JS: Ignore ambience during extractor's variable resolution

Previously, ambient declarations were ignored during variable resolution in the extractor.

However, this makes it difficult to implement name/type resolution in QL, since ambient declaration can affect type checking.

Instead, the extractor's variable resolution no longer cares whether a given declaration is ambient.

The original behaviour was not particularly important to preserve since 'declare' can only appear at the top-level
or inside 'namespace' declarations.

Author: asgerf

javascript/extractor/src/com/semmle/js/extractor/ScopeManager.java

@@ -426,15 +426,13 @@ public Void visit(Identifier nd, Void v) {
       // cases where we turn on the 'declKind' flags
       @Override
       public Void visit(FunctionDeclaration nd, Void v) {
-        if (nd.hasDeclareKeyword() && !isInTypeScriptDeclarationFile()) return null;
         // strict mode functions are block-scoped, non-strict mode ones aren't
         if (blockscope == isStrict) visit(nd.getId(), DeclKind.var);
         return null;
       }
 
       @Override
       public Void visit(ClassDeclaration nd, Void c) {
-        if (nd.hasDeclareKeyword() && !isInTypeScriptDeclarationFile()) return null;
         if (blockscope) visit(nd.getClassDef().getId(), DeclKind.varAndType);
         return null;
       }
@@ -483,7 +481,6 @@ public Void visit(EnhancedForStatement nd, Void v) {
 
       @Override
       public Void visit(VariableDeclaration nd, Void v) {
-        if (nd.hasDeclareKeyword() && !isInTypeScriptDeclarationFile()) return null;
         // in block scoping mode, only process 'let'; in non-block scoping
         // mode, only process non-'let'
         if (blockscope == nd.isBlockScoped(ecmaVersion)) visit(nd.getDeclarations());
@@ -518,8 +515,7 @@ public Void visit(ClassBody nd, Void c) {
       @Override
       public Void visit(NamespaceDeclaration nd, Void c) {
         if (blockscope) return null;
-        boolean isAmbientOutsideDtsFile = nd.hasDeclareKeyword() && !isInTypeScriptDeclarationFile();
-        boolean hasVariable = nd.isInstantiated() && !isAmbientOutsideDtsFile;
+        boolean hasVariable = nd.isInstantiated();
         visit(nd.getName(), hasVariable ? DeclKind.varAndNamespace : DeclKind.namespace);
         return null;
       }

javascript/ql/test/ApiGraphs/typed/NodeOfType.expected

@@ -2,13 +2,34 @@ getANodeOfType
 | body-parser |  | index.ts:4:20:4:41 | require ... arser") |
 | express |  | index.ts:3:17:3:34 | require("express") |
 | mongodb |  | index.ts:1:8:1:19 | * as mongodb |
+| mongodb | AbstractCursor | index.ts:14:3:14:33 | getColl ... d: v }) |
+| mongodb | Collection | index.ts:14:3:14:17 | getCollection() |
+| mongodb | FindCursor | index.ts:14:3:14:33 | getColl ... d: v }) |
+| mongodb | TypedEventEmitter | index.ts:14:3:14:33 | getColl ... d: v }) |
 | mongoose |  | index.ts:17:8:17:20 | * as mongoose |
+| mongoose | AcceptsDiscriminator | index.ts:22:3:22:20 | getMongooseModel() |
+| mongoose | Document | index.ts:22:3:22:20 | getMongooseModel() |
+| mongoose | HydratedDocument | index.ts:22:3:22:20 | getMongooseModel() |
+| mongoose | Model | index.ts:22:3:22:20 | getMongooseModel() |
+| mongoose | Query | index.ts:22:3:22:20 | getMongooseModel() |
+| mongoose | Query | index.ts:22:3:22:36 | getMong ... d: v }) |
+| mongoose | Query | index.ts:23:3:23:20 | getMongooseQuery() |
+| mongoose | Query | index.ts:23:3:23:36 | getMong ... d: v }) |
+| mongoose | QueryWithHelpers | index.ts:22:3:22:36 | getMong ... d: v }) |
+| mongoose | QueryWithHelpers | index.ts:23:3:23:36 | getMong ... d: v }) |
+| mongoose | SessionOperation | index.ts:22:3:22:20 | getMongooseModel() |
+| mongoose | SessionOperation | index.ts:22:3:22:36 | getMong ... d: v }) |
+| mongoose | SessionOperation | index.ts:23:3:23:20 | getMongooseQuery() |
+| mongoose | SessionOperation | index.ts:23:3:23:36 | getMong ... d: v }) |
 | puppeteer |  | index.ts:26:8:26:21 | * as puppeteer |
 | puppeteer | Browser | index.ts:30:22:30:33 | this.browser |
 getANodeOfTypeRaw
 | body-parser |  | index.ts:4:20:4:41 | require ... arser") |
 | express |  | index.ts:3:17:3:34 | require("express") |
 | mongodb |  | index.ts:1:8:1:19 | * as mongodb |
+| mongodb | Collection | index.ts:14:3:14:17 | getCollection() |
 | mongoose |  | index.ts:17:8:17:20 | * as mongoose |
+| mongoose | Model | index.ts:22:3:22:20 | getMongooseModel() |
+| mongoose | Query | index.ts:23:3:23:20 | getMongooseQuery() |
 | puppeteer |  | index.ts:26:8:26:21 | * as puppeteer |
 | puppeteer | Browser | index.ts:30:22:30:33 | this.browser |

javascript/ql/test/ApiGraphs/typed/VerifyAssertions.expected

@@ -1,3 +0,0 @@
-| index.ts:14:36:14:142 | // use= ... "find") | use moduleImport("mongodb").getMember("exports").getMember("Collection") has no outgoing edge labelled getInstance(); it has no outgoing edges at all. |
-| index.ts:22:39:22:157 | // def= ... eter(0) | use moduleImport("mongoose").getMember("exports").getMember("Model") has no outgoing edge labelled getInstance(); it has no outgoing edges at all. |
-| index.ts:23:39:23:157 | // def= ... eter(0) | use moduleImport("mongoose").getMember("exports").getMember("Query") has no outgoing edge labelled getInstance(); it has no outgoing edges at all. |