C#: Deprecate ParameterDefinition in favour of SsaParameterInit.

Author: aschackmull

csharp/ql/lib/semmle/code/csharp/dataflow/SSA.qll

@@ -554,11 +554,9 @@ module Ssa {
   /**
    * DEPRECATED: Use `SsaParameterInit` instead.
    */
-  deprecated class ImplicitParameterDefinition = ParameterDefinition;
+  deprecated final class ImplicitParameterDefinition = SsaImpl::ParameterDefinitionImpl;
 
-  final class ParameterDefinition = SsaImpl::ParameterDefinitionImpl;
-
-  private class ExplicitParameterDefinition extends ExplicitDefinition,
+  deprecated private class ExplicitParameterDefinition extends ExplicitDefinition,
     SsaImpl::ParameterDefinitionImpl
   {
     private Parameter p;

csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImpl.qll

@@ -1048,7 +1048,7 @@ private module DataFlowIntegrationInput implements Impl::DataFlowIntegrationInpu
 
 private module DataFlowIntegrationImpl = Impl::DataFlowIntegration<DataFlowIntegrationInput>;
 
-private module MultiBodyNearestLocationInput implements NearestLocationInputSig {
+deprecated private module MultiBodyNearestLocationInput implements NearestLocationInputSig {
   class C = MultiBodyParameterDefinition;
 
   predicate relevantLocations(MultiBodyParameterDefinition def, Location l1, Location l2) {
@@ -1062,7 +1062,7 @@ private module MultiBodyNearestLocationInput implements NearestLocationInputSig
 }
 
 pragma[nomagic]
-private predicate implicitEntryDef(
+deprecated private predicate implicitEntryDef(
   Ssa::ImplicitEntryDefinition def, Ssa::SourceVariable v, Callable c
 ) {
   v = def.getSourceVariable() and
@@ -1073,7 +1073,7 @@ private predicate implicitEntryDef(
  * An SSA definition representing the implicit initialization of a parameter
  * at the beginning of a callable.
  */
-abstract class ParameterDefinitionImpl extends Ssa::Definition {
+abstract deprecated class ParameterDefinitionImpl extends Ssa::Definition {
   /** Gets the parameter that this definition represents. */
   abstract Parameter getParameter();
 
@@ -1082,7 +1082,9 @@ abstract class ParameterDefinitionImpl extends Ssa::Definition {
   }
 }
 
-class MultiBodyParameterDefinition extends ParameterDefinitionImpl, Ssa::ImplicitEntryDefinition {
+deprecated class MultiBodyParameterDefinition extends ParameterDefinitionImpl,
+  Ssa::ImplicitEntryDefinition
+{
   private Parameter p;
 
   MultiBodyParameterDefinition() {