Potential fix for code scanning alert no. 2: Missed opportunity to use Where

krishnprakash · github-advanced-security[bot] · web-flow · commit 88c576f9cfda · 2025-03-11T14:27:05.000+05:30
Co-authored-by: Copilot Autofix powered by AI &lt;62310815+github-advanced-security[bot]@users.noreply.github.com&gt;
Signed-off-by: Phileco &lt;132178579+krishnprakash@users.noreply.github.com&gt;
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Types/TupleType.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Types/TupleType.cs
@@ -45,10 +45,9 @@ public override void Populate(TextWriter trapFile)
             trapFile.tuple_underlying_type(this, underlyingType);
 
             var index = 0;
-            foreach (var element in TupleElements)
+            foreach (var element in TupleElements.Where(e => e is not null))
             {
-                if (element is not null)
-                    trapFile.tuple_element(this, index++, element);
+                trapFile.tuple_element(this, index++, element);
             }
 
             // Note: symbol.Locations seems to be very inconsistent

Original file line number	Diff line number	Diff line change
`@@ -45,10 +45,9 @@ public override void Populate(TextWriter trapFile)`
`45`	`45`	`trapFile.tuple_underlying_type(this, underlyingType);`
`46`	`46`
`47`	`47`	`var index = 0;`
`48`		`- foreach (var element in TupleElements)`
	`48`	`+ foreach (var element in TupleElements.Where(e => e is not null))`
`49`	`49`	`{`
`50`		`- if (element is not null)`
`51`		`- trapFile.tuple_element(this, index++, element);`
	`50`	`+ trapFile.tuple_element(this, index++, element);`
`52`	`51`	`}`
`53`	`52`
`54`	`53`	`// Note: symbol.Locations seems to be very inconsistent`