Skip to content

Commit 33481f1

Browse files
committed
Add failing test for redefined types
1 parent 2561f3c commit 33481f1

3 files changed

Lines changed: 20 additions & 0 deletions

File tree

go/ql/test/library-tests/semmle/go/dataflow/ExternalFlowInheritance/test_fields.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,3 +83,13 @@ func TestFieldsSEmbedS1AndSEmbedS1(t test.SEmbedS1AndSEmbedS1) {
8383
a := t.SourceField
8484
t.SinkField = a // $ S1[t] ql_S1
8585
}
86+
87+
func TestFieldsRedefinedP1(t test.RedefinedP1) {
88+
a := t.SourceField
89+
t.SinkField = a // $ P1[f] P1[t] ql_P1
90+
}
91+
92+
func TestFieldsRedefinedS1(t test.RedefinedS1) {
93+
a := t.SourceField
94+
t.SinkField = a // $ ql_S1 MISSING: S1[f] S1[t]
95+
}

go/ql/test/library-tests/semmle/go/dataflow/ExternalFlowInheritance/test_methods.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,3 +171,9 @@ func TestMethodsSEmbedS1AndSEmbedS1(t test.SEmbedS1AndSEmbedS1) {
171171
y := t.Step(x)
172172
t.Sink(y) // $ I1[t] S1[t] ql_S1
173173
}
174+
175+
func TestMethodsRedefinedI1(t test.RedefinedI1) {
176+
x := t.Source()
177+
y := t.Step(x)
178+
t.Sink(y) // $ ql_I1 MISSING: I1[f] I1[t] SPURIOUS: ql_P1 ql_S1
179+
}

go/ql/test/library-tests/semmle/go/dataflow/ExternalFlowInheritance/vendor/github.com/nonexistent/test/stub.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)