Fix missing check for qualifiers on members returning subobject refs

knewbury01 · knewbury01 · commit 81375faeca89 · 2026-04-29T17:18:39.000-04:00
diff --git a/cpp/misra/src/rules/RULE-6-8-4/MemberFunctionsRefqualified.ql b/cpp/misra/src/rules/RULE-6-8-4/MemberFunctionsRefqualified.ql
@@ -52,6 +52,7 @@ class MembersReturningSubObject extends MembersReturningObjectOrSubobject {
   MembersReturningSubObject() {
     exists(ReturnStmt r, FieldAccess access, Expr e |
       r.getEnclosingFunction() = this and
+      (not exists(access.getQualifier()) or access.getQualifier() instanceof ThisExpr) and
       (
         //subobject returned by address
         r.getAChild() = access.getParent() and

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ class MembersReturningSubObject extends MembersReturningObjectOrSubobject {`
`52`	`52`	`MembersReturningSubObject() {`
`53`	`53`	`exists(ReturnStmt r, FieldAccess access, Expr e \|`
`54`	`54`	`r.getEnclosingFunction() = this and`
	`55`	`+ (not exists(access.getQualifier()) or access.getQualifier() instanceof ThisExpr) and`
`55`	`56`	`(`
`56`	`57`	`//subobject returned by address`
`57`	`58`	`r.getAChild() = access.getParent() and`