Review feedback

Author: MichaelRFairhurst

cpp/misra/src/rules/RULE-15-0-1/AnalyzableClass.qll

@@ -51,7 +51,7 @@ private predicate isUserDeclared(MemberFunction f) { not f.isCompilerGenerated()
  * Holds if the implicit move constructor or move assignment operator of the class `c` will not be
  * declared.
  *
- * See [class.copy]/8 and [class.copy]
+ * Specified in [class.copy.ctor]/8 and [class.copy.assign]/4.
  */
 private predicate implicitMoveIsSuppressed(Class c) {
   isUserDeclared(c.getAConstructor().(CopyConstructor))

cpp/misra/src/rules/RULE-15-0-1/ImproperlyProvidedSpecialMemberFunctions.ql

@@ -82,12 +82,11 @@ predicate violatesCustomizedMoveOrCopyRequirements(AnalyzableClass c, string rea
 private predicate undeclaredMoveException(AnalyzableClass c) {
   // A copy-enabled class may have an undeclared move constructor.
   isCopyEnabled(c) and
-  not c.moveAssignable() and
+  not c.copyAssignable() and
   not c.declaresMoveConstructor()
   or
   // A copy-assignable class may leave both move operations undeclared.
-  isCopyEnabled(c) and
-  c.moveAssignable() and
+  c.copyAssignable() and
   not c.declaresMoveConstructor() and
   not c.declaresMoveAssignmentOperator()
 }

cpp/misra/test/rules/RULE-15-0-1/ImproperlyProvidedSpecialMemberFunctions.expected

@@ -35,3 +35,5 @@
 | test.cpp:346:7:346:33 | UnmovableBaseNonvirtualDtor | Class 'UnmovableBaseNonvirtualDtor' violates inheritance requirements for special member functions. |
 | test.cpp:369:7:369:33 | UnmovablePrivateVirtualDtor | Class 'UnmovablePrivateVirtualDtor' violates inheritance requirements for special member functions. |
 | test.cpp:398:7:398:30 | BaseVirtualProtectedDtor | Class 'BaseVirtualProtectedDtor' violates inheritance requirements for special member functions. |
+| test.cpp:439:7:439:26 | NonTrivialDestructor | Class 'NonTrivialDestructor' has customized the destructor, but does not customize the copy assignment operator. |
+| test.cpp:439:7:439:26 | NonTrivialDestructor | Class 'NonTrivialDestructor' has customized the destructor, but does not customize the copy constructor. |

cpp/misra/test/rules/RULE-15-0-1/ImproperlyProvidedSpecialMemberFunctionsAudit.expected

@@ -5,4 +5,4 @@
 | test.cpp:410:7:410:33 | VirtualProtectedDtorDerived | Class 'VirtualProtectedDtorDerived' is not analyzable because the move assignment operator is not present in the CodeQL database. |
 | test.cpp:423:8:423:19 | TrivialClass | Class 'TrivialClass' is not analyzable because the destructor and move assignment operator and move constructor are not present in the CodeQL database. |
 | test.cpp:429:7:429:21 | NonTrivialClass | Class 'NonTrivialClass' is not analyzable because the copy constructor and move assignment operator and move constructor are not present in the CodeQL database. |
-| test.cpp:439:7:439:14 | CopyOnly | Class 'CopyOnly' is not analyzable because the destructor is not present in the CodeQL database. |
+| test.cpp:450:7:450:14 | CopyOnly | Class 'CopyOnly' is not analyzable because the destructor is not present in the CodeQL database. |

cpp/misra/test/rules/RULE-15-0-1/test.cpp

@@ -413,7 +413,7 @@ class VirtualProtectedDtorDerived : public BaseVirtualProtectedDtor {};
 
 } // namespace fully_specified
 
-namespace audit_results {
+namespace implicit_special_members {
 
 struct PodClass { // COMPLIANT - we know PODs are OK.
   int x;
@@ -434,6 +434,17 @@ class NonTrivialClass { // NON_COMPLIANT - audit result
   ~NonTrivialClass() { x = 1; }
 };
 
+// CodeQL resolves and stores all of the special member functions in the
+// database for this class, so it is not an audit query result.
+class NonTrivialDestructor { // NON_COMPLIANT - uncustomized copy ops.
+  int x;
+  int y;
+
+public:
+  COPY_CTOR(NonTrivialDestructor) = default;
+  ~NonTrivialDestructor() { x = 1; }
+};
+
 // This class is not a valid category but hard to analyze in the general case.
 // This should not be reported as a violation except by the audit query.
 class CopyOnly { // NON_COMPLIANT - audit result
@@ -460,4 +471,4 @@ void f(OdrUsedMoveEnabled o) {
   o3 = std::move(o);
 }
 
-} // namespace audit_results
+} // namespace implicit_special_members