SDK-1299: Remove MediaReponse, add content property to YotiResponse containing raw bytes from response

Author: MrBurtyyy

yoti_python_sdk/doc_scan/client.py

@@ -12,7 +12,6 @@
     GetSessionResult,
 )
 from yoti_python_sdk.doc_scan.session.retrieve.media_value import MediaValue
-from yoti_python_sdk.http import MediaRequestHandler
 from yoti_python_sdk.http import SignedRequest
 from yoti_python_sdk.utils import YotiEncoder
 from .exception import DocScanException
@@ -129,7 +128,6 @@ def get_media_content(self, session_id, media_id):
         """
         request = (
             SignedRequest.builder()
-            .with_request_handler(MediaRequestHandler)
             .with_get()
             .with_pem_file(self.__key)
             .with_base_url(self.__api_url)

yoti_python_sdk/http.py

@@ -24,12 +24,13 @@
 
 
 class YotiResponse(object):
-    def __init__(self, status_code, text, headers=None):
+    def __init__(self, status_code, text, headers=None, content=None):
         if headers is None:
             headers = {}
 
         self.status_code = status_code
         self.text = text
+        self.content = content
         self.headers = headers
 
 
@@ -89,27 +90,10 @@ def execute(request):
             status_code=response.status_code,
             text=response.text,
             headers=response.headers,
+            content=response.content,
         )
 
 
-class MediaRequestHandler(RequestHandler):
-    @staticmethod
-    def execute(request):
-        """
-        Execute the HTTP request supplied
-        """
-        if not isinstance(request, SignedRequest):
-            raise TypeError("RequestHandler expects instance of SignedRequest")
-
-        response = requests.request(
-            url=request.url,
-            method=request.method,
-            data=request.data,
-            headers=request.headers,
-        )
-        return MediaResponse(response)
-
-
 class SignedRequest(object):
     def __init__(self, url, http_method, payload, headers, request_handler=None):
         self.__url = url

yoti_python_sdk/tests/doc_scan/mocks.py

@@ -32,7 +32,8 @@ def mocked_request_failed_session_retrieval():
 def mocked_request_media_content():
     return MockResponse(
         status_code=200,
-        text=b"someContent",
+        text="someContent",
+        content=b"someContent",
         headers={"Content-Type": "application/json"},
     )
 

yoti_python_sdk/tests/mocks.py

@@ -7,15 +7,11 @@
 
 
 class MockResponse(YotiResponse):
-    def __init__(self, status_code, text, headers=None):
+    def __init__(self, status_code, text, headers=None, content=None):
         if headers is None:
             headers = dict()
 
-        super(MockResponse, self).__init__(status_code, text, headers)
-
-    @property
-    def content(self):
-        return self.text
+        super(MockResponse, self).__init__(status_code, text, headers, content)
 
 
 class MockRequestHandler(RequestHandler):