SDK-722: Rename methods from wanted_attribute_builder to conform to PEP8

Author: emmas-yoti

yoti_python_sdk/dynamic_sharing_service/policy/dynamic_policy_builder.py

@@ -39,7 +39,7 @@ def with_wanted_attribute(self, wanted_attribute):
     """
 
     def with_wanted_attribute_by_name(self, wanted_name):
-        attribute = WantedAttributeBuilder().withName(wanted_name).build()
+        attribute = WantedAttributeBuilder().with_name(wanted_name).build()
         return self.with_wanted_attribute(attribute)
 
     def with_family_name(self):
@@ -57,8 +57,8 @@ def with_date_of_birth(self):
     def with_age_derived_attribute(self, derivation):
         attribute = (
             WantedAttributeBuilder()
-            .withName(config.ATTRIBUTE_DATE_OF_BIRTH)
-            .withDerivation(derivation)
+            .with_name(config.ATTRIBUTE_DATE_OF_BIRTH)
+            .with_derivation(derivation)
             .build()
         )
         return self.with_wanted_attribute(attribute)

yoti_python_sdk/dynamic_sharing_service/policy/wanted_attribute_builder.py

@@ -10,25 +10,22 @@ class WantedAttributeBuilder(object):
     def __init__(self):
         self.__attribute = {}
 
-    """
-    @param name Sets name
-    """
-
-    def withName(self, name):
+    def with_name(self, name):
+        """
+        :param name: Sets name
+        """
         self.__attribute["name"] = name
         return self
 
-    """
-    @param derivation Sets derivation
-    """
-
-    def withDerivation(self, derivation):
+    def with_derivation(self, derivation):
+        """
+        :param derivation: Sets derivation
+        """
         self.__attribute["derivation"] = derivation
         return self
 
-    """
-    @return The wanted attribute object
-    """
-
     def build(self):
+        """
+        :return: The wanted attribute object
+        """
         return self.__attribute.copy()

yoti_python_sdk/tests/dynamic_sharing_service/policy/test_dynamic_policy_builder.py

@@ -11,7 +11,7 @@
 def test_an_attribute_can_only_exist_once():
     NAME = "Test name"
 
-    wanted_attribute = WantedAttributeBuilder().withName(NAME).build()
+    wanted_attribute = WantedAttributeBuilder().with_name(NAME).build()
 
     policy = (
         DynamicPolicyBuilder()

yoti_python_sdk/tests/dynamic_sharing_service/policy/test_wanted_attribute_builder.py

@@ -9,7 +9,7 @@ def test_build():
 
     builder = WantedAttributeBuilder()
 
-    attribute = builder.withName(NAME).withDerivation(DERIVATION).build()
+    attribute = builder.with_name(NAME).with_derivation(DERIVATION).build()
 
     assert attribute["name"] == NAME
     assert attribute["derivation"] == DERIVATION