From 10147ea38db37291c647cc076ef906c404b2c9b2 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 19 Jun 2026 03:13:41 +0000 Subject: [PATCH] ref(eap-items): use ConditionFunctions.EQ instead of hardcoded "equals" Address review nit: reference the ConditionFunctions.EQ constant rather than the hardcoded "equals" string in IndexedNameOptimizer. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_01CajnvSCYTxvJ9Hw5jELRPH --- .../query/processors/logical/indexed_name_optimizer.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/snuba/query/processors/logical/indexed_name_optimizer.py b/snuba/query/processors/logical/indexed_name_optimizer.py index a44a994895..c2187b3abd 100644 --- a/snuba/query/processors/logical/indexed_name_optimizer.py +++ b/snuba/query/processors/logical/indexed_name_optimizer.py @@ -2,7 +2,10 @@ from sentry_protos.snuba.v1.request_common_pb2 import TraceItemType -from snuba.query.conditions import get_first_level_and_conditions +from snuba.query.conditions import ( + ConditionFunctions, + get_first_level_and_conditions, +) from snuba.query.expressions import ( Column, Expression, @@ -54,7 +57,10 @@ def _indexed_name_key(self, query: Query) -> Optional[str]: item_types: set[int] = set() for cond in get_first_level_and_conditions(condition): - if not isinstance(cond, FunctionCall) or cond.function_name != "equals": + if ( + not isinstance(cond, FunctionCall) + or cond.function_name != ConditionFunctions.EQ + ): continue if len(cond.parameters) != 2: continue