From d5c7e1c6ba130cfbb869055578b5c4e557fe33ea Mon Sep 17 00:00:00 2001 From: s1gr1d <32902192+s1gr1d@users.noreply.github.com> Date: Tue, 17 Nov 2026 11:52:22 +0100 Subject: [PATCH 1/3] ci: Ignore npm deprecation notices in the lockfile check The lockfile stores the deprecation message of each package. When a maintainer deprecates a locked version on npm, `pnpm install` and `pnpm dedupe --check` want to add that line. The check then failed on develop without a change in the repository, in 19 runs in one month. Both steps now compare the lockfile with `git diff -I` and ignore these lines. --- .github/workflows/build.yml | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a29c36743adb..e4b197e4e7c0 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -353,7 +353,7 @@ jobs: job_check_lockfile: name: Check lockfile needs: [job_get_metadata] - # `pnpm dedupe --check` fetches metadata for every package from npm, so this job can take 8+ min on PRs. + # `pnpm dedupe` fetches metadata for every package from npm, so this job can take 8+ min on PRs. timeout-minutes: 20 runs-on: ubuntu-24.04 if: | @@ -371,14 +371,21 @@ jobs: uses: ./.github/actions/setup-node - name: Install dependencies run: pnpm install --no-frozen-lockfile + # The lockfile stores the deprecation message of each package. A maintainer can deprecate a locked version on + # npm at any time, which changes the lockfile without a change in this repository. Both checks ignore these lines. - name: Check that pnpm-lock.yaml is stable run: | - if ! git diff --exit-code pnpm-lock.yaml; then + if ! git diff --exit-code -I'^ +deprecated: ' pnpm-lock.yaml; then echo "::error::pnpm-lock.yaml has uncommitted changes after running 'pnpm install'. Please run 'pnpm install' locally and commit the updated pnpm-lock.yaml." exit 1 fi - name: Check for duplicate dependencies in lockfile - run: pnpm run dedupe-deps:check + run: | + pnpm dedupe --lockfile-only + if ! git diff --exit-code -I'^ +deprecated: ' pnpm-lock.yaml; then + echo "::error::pnpm-lock.yaml has duplicate dependencies. Please run 'pnpm run dedupe-deps:fix' locally and commit the updated pnpm-lock.yaml." + exit 1 + fi job_check_format: name: Check file formatting From cd2e0b926ca06a969e0c4a783d9272c8be5242cb Mon Sep 17 00:00:00 2001 From: s1gr1d <32902192+s1gr1d@users.noreply.github.com> Date: Tue, 17 Nov 2026 11:52:22 +0100 Subject: [PATCH 2/3] ci: Skip Playwright's host validation for headless WebKit The action installs only the libraries of the headless WebKit executable. Before a launch, Playwright validates the libraries of all WebKit executables, unless the browser directory holds a `DEPENDENCIES_VALIDATED` marker that is younger than 30 days. The cached browsers hold a marker from 2026-11-04. WebKit jobs passed only with a cache hit, and all of them would fail from 2026-12-04. --- .github/actions/install-playwright/action.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/actions/install-playwright/action.yml b/.github/actions/install-playwright/action.yml index b642f77815d3..b9f554031f9b 100644 --- a/.github/actions/install-playwright/action.yml +++ b/.github/actions/install-playwright/action.yml @@ -109,6 +109,14 @@ runs: install -y --no-install-recommends "${packages[@]}" shell: bash + # Before a launch, Playwright also checks the libraries of the GTK executable, which headless tests do not start + # and the list above does not have. Without this, a launch only works while the browser cache holds Playwright's + # `DEPENDENCIES_VALIDATED` marker, which expires after 30 days. + - name: Skip Playwright's host validation + if: steps.webkit-dependencies.outputs.key != '' + run: echo "PLAYWRIGHT_SKIP_VALIDATE_HOST_REQUIREMENTS=1" >> "$GITHUB_ENV" + shell: bash + - name: Remove obsolete cached WebKit packages if: steps.webkit-dependencies.outputs.key != '' && steps.webkit-apt-cache.outputs.cache-hit != 'true' && From e7cae4619a910d3858a66e41e94eebee3abc8fd5 Mon Sep 17 00:00:00 2001 From: s1gr1d <32902192+s1gr1d@users.noreply.github.com> Date: Tue, 17 Nov 2026 11:52:22 +0100 Subject: [PATCH 3/3] test: Stop collecting coverage and junit reports by default No workflow reads the coverage or junit output since Codecov was removed (#20803). Coverage makes the unit tests of `@sentry/core` about three times slower (66 s against 24 s locally), which pushes slow tests over their timeout on a busy CI runner. Vitest adds the `github-actions` reporter by itself, so the CI annotations stay. Use `vitest --coverage` to collect coverage. --- .gitignore | 2 -- dev-packages/bun-integration-tests/vite.config.mts | 3 --- dev-packages/cloudflare-integration-tests/vite.config.mts | 3 --- dev-packages/deno-integration-tests/vite.config.mts | 3 --- dev-packages/node-integration-tests/vite.config.ts | 3 --- vite/vite.config.ts | 7 ------- 6 files changed, 21 deletions(-) diff --git a/.gitignore b/.gitignore index 09a467ba61e7..3aa61966f000 100644 --- a/.gitignore +++ b/.gitignore @@ -65,8 +65,6 @@ packages/gatsby/gatsby-node.d.ts *.iml /**/.wrangler/* -#junit reports -packages/**/*.junit.xml # Local Claude Code settings that should not be committed .claude/settings.local.json diff --git a/dev-packages/bun-integration-tests/vite.config.mts b/dev-packages/bun-integration-tests/vite.config.mts index f339cd917a02..2f741bdc0768 100644 --- a/dev-packages/bun-integration-tests/vite.config.mts +++ b/dev-packages/bun-integration-tests/vite.config.mts @@ -26,9 +26,6 @@ export default defineConfig({ ...baseConfig, test: { ...baseConfig.test, - coverage: { - enabled: false, - }, isolate: false, testTimeout: 20_000, ...(process.env.DEBUG diff --git a/dev-packages/cloudflare-integration-tests/vite.config.mts b/dev-packages/cloudflare-integration-tests/vite.config.mts index 600cd6a118ee..ab1043476e3d 100644 --- a/dev-packages/cloudflare-integration-tests/vite.config.mts +++ b/dev-packages/cloudflare-integration-tests/vite.config.mts @@ -5,9 +5,6 @@ export default defineConfig({ ...baseConfig, test: { ...baseConfig.test, - coverage: { - enabled: false, - }, isolate: false, include: ['./suites/**/test.ts'], // Each test spawns its own `wrangler dev` (cold workerd boot) and waits for envelopes to be diff --git a/dev-packages/deno-integration-tests/vite.config.mts b/dev-packages/deno-integration-tests/vite.config.mts index 6dccfdc74a5e..7fa33df4e90f 100644 --- a/dev-packages/deno-integration-tests/vite.config.mts +++ b/dev-packages/deno-integration-tests/vite.config.mts @@ -10,9 +10,6 @@ export default defineConfig({ test: { ...baseConfig.test, root: fileURLToPath(new URL('../node-integration-tests', import.meta.url)), - coverage: { - enabled: false, - }, isolate: false, include: ['suites/**/test.ts'], exclude: NODE_SUITES_EXCLUDE, diff --git a/dev-packages/node-integration-tests/vite.config.ts b/dev-packages/node-integration-tests/vite.config.ts index 5a8b87af8dce..ebc66759236e 100644 --- a/dev-packages/node-integration-tests/vite.config.ts +++ b/dev-packages/node-integration-tests/vite.config.ts @@ -6,9 +6,6 @@ export default defineConfig({ test: { ...baseConfig.test, isolate: false, - coverage: { - enabled: false, - }, include: ['./**/test.ts'], testTimeout: 15000, // Ensure we can see debug output when DEBUG=true diff --git a/vite/vite.config.ts b/vite/vite.config.ts index 5c6e36c55c0d..2152c68b2fb2 100644 --- a/vite/vite.config.ts +++ b/vite/vite.config.ts @@ -22,7 +22,6 @@ export default defineConfig({ }, test: { coverage: { - enabled: true, reportsDirectory: './coverage', exclude: [ '**/node_modules/**', @@ -35,12 +34,6 @@ export default defineConfig({ 'vite.config.*', ], }, - reporters: process.env.CI - ? ['default', 'github-actions', ['junit', { classnameTemplate: '{filepath}' }]] - : ['default'], - outputFile: { - junit: 'vitest.junit.xml', - }, typecheck: { tsconfig: './tsconfig.test.json', },