Skip to content

Commit d85d55a

Browse files
committed
deslop a bit
1 parent 0acd944 commit d85d55a

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

‎dev-packages/node-integration-tests/suites/tracing/sampling-static/test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ describe('negative sampling (static)', () => {
99
createEsmAndCjsTests(__dirname, 'server.mjs', 'instrument.mjs', (createRunner, test) => {
1010
test('records sample_rate outcomes for the transaction and all of its spans', async () => {
1111
// `/health` and `/ok` go through the same middleware, so the `/ok` transaction tells us how many
12-
// spans the dropped `/health` transaction had. The count differs per runtime (e.g. Bun creates
13-
// no Express spans), so derive it instead of hardcoding it.
12+
// spans the dropped `/health` transaction woudl have had. The count differs per runtime (e.g. Bun creates
13+
// no Express spans), so we derive it instead of hardcoding it.
1414
let okSpanCount: number | undefined;
1515
let droppedSpanCount: number | undefined;
1616

‎packages/core/src/tracing/sentrySpan.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,6 @@ export class SentrySpan implements Span {
369369
return;
370370
}
371371

372-
// The `sample_rate` outcome was already recorded when the span was started (see `_startRootSpan`).
373372
DEBUG_BUILD && debug.log('[Tracing] Discarding standalone span because its trace was not chosen to be sampled.');
374373
return;
375374
}

‎packages/core/src/tracing/trace.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ function _startRootSpan(
525525
DEBUG_BUILD && debug.log('[Tracing] Discarding root span because its trace was not chosen to be sampled.');
526526
const outcomeReason = dropReason || 'sample_rate';
527527
// A standalone span is sent on its own and never becomes a transaction.
528-
// TODO(standalone): drop the `isStandalone` check once the static trace lifecycle is gone.
528+
// TODO(v12): Drop the `isStandalone` check once the static trace lifecycle is gone.
529529
if (!hasSpanStreamingEnabled(client) && !spanArguments.isStandalone) {
530530
client.recordDroppedEvent(outcomeReason, 'transaction');
531531
}

0 commit comments

Comments
 (0)