Skip to content

Commit cdf0bcf

Browse files
mydeaclaude
andcommitted
test(e2e): Type-check the react-router-7-router-entry app
The v7 router-entry app only ran Playwright and its tsconfig used `moduleResolution: "node"`, which ignores the package `exports` map and so cannot resolve the `@sentry/react/router` subpath types - meaning it never type-checked the new API, unlike the v6/v8 apps. Switch it to `moduleResolution: "bundler"` and run `tsc --noEmit` in `test:assert`, matching the other two. Verified locally that all three (v6/v7/v8) type-check against their respective React Router major. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 25dfebd commit cdf0bcf

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎dev-packages/e2e-tests/test-applications/react-router-7-router-entry/package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,10 @@
2323
"preview": "vite preview",
2424
"test": "playwright test",
2525
"clean": "npx rimraf node_modules pnpm-lock.yaml",
26+
"typecheck": "tsc --noEmit",
2627
"test:build": "pnpm install && pnpm build",
2728
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
28-
"test:assert": "pnpm test"
29+
"test:assert": "pnpm typecheck && pnpm test"
2930
},
3031
"eslintConfig": {
3132
"extends": [

‎dev-packages/e2e-tests/test-applications/react-router-7-router-entry/tsconfig.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"forceConsistentCasingInFileNames": true,
1111
"noFallthroughCasesInSwitch": true,
1212
"module": "esnext",
13-
"moduleResolution": "node",
13+
"moduleResolution": "bundler",
1414
"resolveJsonModule": true,
1515
"isolatedModules": true,
1616
"noEmit": true,

0 commit comments

Comments
 (0)