Skip to content

Commit c12cded

Browse files
committed
fix(browser): stop tagging DOMException.code on events
Fixes #10501
1 parent 449b642 commit c12cded

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

‎packages/browser/src/eventbuilder.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -302,10 +302,6 @@ export function eventFromUnknownInput(
302302
event = eventFromString(stackParser, message, syntheticException, attachStacktrace);
303303
addExceptionTypeValue(event, message);
304304
}
305-
if ('code' in domException) {
306-
// eslint-disable-next-line typescript/no-deprecated
307-
event.tags = { ...event.tags, 'DOMException.code': `${domException.code}` };
308-
}
309305

310306
return event;
311307
}

‎packages/browser/test/eventbuilder.test.ts‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,15 @@ describe('eventFromUnknownInput', () => {
294294
}),
295295
);
296296
});
297+
298+
it('does not set the deprecated DOMException.code as an event tag', () => {
299+
const exception = new DOMException('Permission denied', 'NotAllowedError');
300+
301+
const event = eventFromUnknownInput(defaultStackParser, exception);
302+
303+
expect(event.exception?.values?.[0]?.type).toBe('NotAllowedError');
304+
expect(event.tags).toBeUndefined();
305+
});
297306
});
298307

299308
describe('extractMessage', () => {

0 commit comments

Comments
 (0)