Skip to content

Commit be4d02d

Browse files
committed
better comment
1 parent 1540609 commit be4d02d

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

  • packages/server-utils/src/orchestrion/bundler

‎packages/server-utils/src/orchestrion/bundler/vite.ts‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,6 @@ export function sentryOrchestrionPlugin(options: PluginOptions = {}): Plugin {
9999
// ESM entry — a link-time crash at server startup. Bundling sidesteps
100100
// external ESM/CJS interop on both Vite majors, and the ESM barrel
101101
// tree-shakes to just the helper and the factories actually referenced.
102-
//
103-
// Note: we deliberately do NOT force `@sentry/node` into `ssr.external`
104-
// here. Vite already externalizes it for node SSR by default (so the
105-
// runtime hook resolves from `node_modules`), and this same plugin also
106-
// runs in worker builds (`@sentry/cloudflare`, frameworks on
107-
// `@cloudflare/vite-plugin`) where `@sentry/node` is unused and setting
108-
// `resolve.external` is rejected outright. The runtime probe in
109-
// `orchestrion/register` covers the cases where it does get bundled.
110102
return {
111103
ssr: { noExternal: [...instrumentedModuleNames(options.instrumentations), '@sentry/server-utils'] },
112104
};

0 commit comments

Comments
 (0)