further deslop

Author: Lms24

packages/astro/src/server/middleware.ts

@@ -108,7 +108,7 @@ export const handleRequest: (options?: MiddlewareOptions) => MiddlewareHandler =
     const rootSpan = activeSpan ? getRootSpan(activeSpan) : undefined;
 
     // if there is an active span, we just want to enhance it with routing data etc.
-    if (rootSpan && spanToJSON(rootSpan).attributes[SENTRY_OP] === 'http.server') {
+    if (rootSpan && spanToJSON(rootSpan).attributes[SENTRY_OP] === HTTP_SERVER) {
       return enhanceHttpServerSpan(ctx, next, rootSpan);
     }
 
@@ -253,7 +253,7 @@ async function instrumentRequestStartHttpServerSpan(
           const res = await startSpan(
             {
               attributes: {
-                [SENTRY_OP]: 'http.server',
+                [SENTRY_OP]: HTTP_SERVER,
                 ...attributes,
               },
               name,

packages/browser/src/tracing/browserTracingIntegration.ts

@@ -5,7 +5,6 @@ import type {
   RequestHookInfo,
   ResponseHookInfo,
   Span,
-  SpanAttributes,
   StartSpanOptions,
 } from '@sentry/core/browser';
 import {
@@ -345,7 +344,7 @@ export const browserTracingIntegration = ((options: Partial<BrowserTracingOption
     // For pageloads (and manual navigation spans without a URL) we fall back to the current location.
     const urlObject = parseStringToURLObject(url || getLocationHref());
 
-    const attributes: SpanAttributes = {
+    const attributes = {
       ...(urlObject?.pathname && { [URL_PATH]: urlObject.pathname }),
       ...(urlObject && !isURLObjectRelative(urlObject) && { [URL_FULL]: filterCollectedUrl(urlObject.href) }),
       ...finalStartSpanOptions.attributes,

packages/core/src/types/startSpanOptions.ts

@@ -54,23 +54,24 @@ export interface StartSpanOptions {
    *
    * @deprecated This option will be removed in the next major version of the SDK. There is no longer a concrete use
    * case for it: all spans are indexed and searchable in Sentry, so a span no longer needs to be a transaction to be
-   * queried, filtered or aggregated on. In most cases, simply drop the option - the span is still sent, just as a child
-   * of its parent span. If you do need the span to be a segment (root) span, start it without a parent span instead.
+   * queried, filtered or aggregated on. In most cases, simply drop the option. The span is still sent, just as a child
+   * of its parent span, if a parent span is active.
+   * If you do need the span to be a segment (root) span, follow the examples below:.
    *
-   * @example Making a span a segment span without forcing it into a transaction
+   * @example Making a span a root span:
    * ```js
    * Sentry.withActiveSpan(null, () => {
-   *   Sentry.startSpan({ name: 'span-that-should-be-a-segment' }, () => {
+   *   Sentry.startSpan({ name: 'span-that-should-be-a-root' }, () => {
    *     // ...
    *   });
    * });
    * ```
    *
-   * @example Keeping that segment span attached to an incoming trace
+   * @example Keeping the root span attached to a specific trace:
    * ```js
    * Sentry.continueTrace({ sentryTrace, baggage }, () =>
    *   Sentry.withActiveSpan(null, () =>
-   *     Sentry.startSpan({ name: 'span-that-should-be-a-segment' }, () => {
+   *     Sentry.startSpan({ name: 'span-that-should-be-a-root' }, () => {
    *       // ...
    *     }),
    *   ),