Skip to content

Commit 150d7a8

Browse files
authored
Apply batched suggestions from code review
Co-authored-by: isaacs <i@izs.me>
1 parent 3bf35eb commit 150d7a8

3 files changed

Lines changed: 3 additions & 5 deletions

File tree

‎packages/deno/src/index.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ export { getDefaultIntegrations, init } from './sdk';
110110
export { denoServeIntegration } from './integrations/deno-serve';
111111
export type { DenoServeIntegrationOptions } from './integrations/deno-serve';
112112
export { fetchIntegration } from './integrations/fetch';
113+
export type { FetchOptions } from './integrations/fetch';
113114
export { denoHttpIntegration } from './integrations/http';
114115
export type { DenoHttpIntegrationOptions } from './integrations/http';
115116

‎packages/deno/src/integrations/fetch.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,6 @@ const _fetchIntegration = ((options: FetchOptions = {}) => {
8282

8383
/**
8484
* Instruments outgoing `fetch` requests in Deno by creating spans and attaching trace propagation headers.
85-
* The separate breadcrumbs integration continues to record fetch breadcrumbs.
85+
* The separate breadcrumbs integration records fetch breadcrumbs.
8686
*/
8787
export const fetchIntegration = defineIntegration(_fetchIntegration);

‎packages/deno/test/deno-fetch.test.ts‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,11 @@ Deno.test({
4242
resetGlobals();
4343

4444
const abortController = new AbortController();
45-
let onListen: ((value: unknown) => void) | undefined;
46-
const listening = new Promise(resolve => (onListen = resolve));
4745
let receivedHeaders: Headers | undefined;
48-
const server = Deno.serve({ port: 0, signal: abortController.signal, onListen, hostname: '127.0.0.1' }, request => {
46+
const server = Deno.serve({ port: 0, signal: abortController.signal, onListen() {}, hostname: '127.0.0.1' }, request => {
4947
receivedHeaders = request.headers;
5048
return new Response('ok');
5149
});
52-
await listening;
5350

5451
try {
5552
const url = `http://127.0.0.1:${server.addr.port}/downstream`;

0 commit comments

Comments
 (0)