Commit 12100c6
fix(nestjs): Follow the
The `@OnEvent` handler span was named `event <name>` and set no
`code.function.name`, so the `event ` prefix was derivable from nothing
and Relay could infer no description at all for it. Both the name and
the description conventions for the `function` op are built from
`code.function.name`.
Name the span after the event the handler listens to and set that as
`code.function.name`. The event is the closest thing to an identity the
SDK has for an `@OnEvent` handler, and it is what made the old name
useful. The prefixed name moves to `sentry.description`, matching what
the bullmq helper next to it already does.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>function conventions for @OnEvent span names1 parent 5b691f0 commit 12100c6
4 files changed
Lines changed: 49 additions & 9 deletions
File tree
- dev-packages/e2e-tests/test-applications/nestjs-distributed-tracing/tests
- packages/nestjs
- src/integrations
- test/integrations
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1036 | 1036 | | |
1037 | 1037 | | |
1038 | 1038 | | |
| 1039 | + | |
1039 | 1040 | | |
1040 | 1041 | | |
1041 | 1042 | | |
| |||
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
53 | 55 | | |
54 | 56 | | |
55 | 57 | | |
| |||
100 | 102 | | |
101 | 103 | | |
102 | 104 | | |
103 | | - | |
| 105 | + | |
104 | 106 | | |
105 | 107 | | |
106 | 108 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
| |||
111 | 113 | | |
112 | 114 | | |
113 | 115 | | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
114 | 120 | | |
115 | | - | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
116 | 124 | | |
117 | 125 | | |
| 126 | + | |
118 | 127 | | |
| 128 | + | |
| 129 | + | |
119 | 130 | | |
120 | 131 | | |
121 | 132 | | |
| |||
Lines changed: 30 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
876 | 876 | | |
877 | 877 | | |
878 | 878 | | |
879 | | - | |
| 879 | + | |
880 | 880 | | |
| 881 | + | |
| 882 | + | |
881 | 883 | | |
882 | 884 | | |
883 | 885 | | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
884 | 910 | | |
885 | 911 | | |
886 | 912 | | |
| |||
1014 | 1040 | | |
1015 | 1041 | | |
1016 | 1042 | | |
1017 | | - | |
1018 | | - | |
| 1043 | + | |
| 1044 | + | |
1019 | 1045 | | |
1020 | 1046 | | |
1021 | 1047 | | |
1022 | | - | |
| 1048 | + | |
1023 | 1049 | | |
1024 | 1050 | | |
1025 | 1051 | | |
| |||
0 commit comments