Repository navigation
fix(feedback): Improve dialog keyboard access and input contrast #65364
build.yml
on: pull_request
Get CI Metadata
/
Get Metadata
7s
Check PR branches
4s
Matrix: job_bun_integration_tests
Matrix: job_bun_unit_tests
Matrix: job_bundler_plugin_integration_tests
Matrix: job_cloudflare_integration_tests
Matrix: job_deno_integration_tests
Matrix: job_node_integration_tests
Matrix: job_node_unit_tests
Lint
1m 34s
Browser Unit Tests
2m 16s
Deno Unit Tests
0s
SQL Server Integration Tests (Node 24)
0s
Matrix: job_optional_cloudflare_integration_tests
Matrix: job_e2e_tests_1
Matrix: job_e2e_tests_2
E2E Tests (optional)
Matrix: job_browser_loader_tests
Matrix: job_browser_playwright_tests
Matrix: job_e2e_aws_layer_tests
All required jobs passed or were skipped
4s
Annotations
6 errors, 2 warnings, and 248 notices
|
E2E nuxt-5 (tunnel-basepath) Test
Process completed with exit code 1.
|
|
Size Check
One or more gzipped bundles increased by more than 500 bytes. If this increase is intentional, add the **Accept Bundlesize Increase** label to this PR to rerun and accept the check.
|
|
Playwright bundle_tracing_replay_feedback_logs_metrics_min webkit (1/2) Tests
Process completed with exit code 1.
|
|
[webkit] βΊ suites/feedback/accessibility/test.ts:89:11 βΊ programmatic close and removal release modal state and preserve body overflow @firefox:
dev-packages/browser-integration-tests/suites/feedback/accessibility/test.ts#L107
2) [webkit] βΊ suites/feedback/accessibility/test.ts:89:11 βΊ programmatic close and removal release modal state and preserve body overflow @Firefox
Error: expect(locator).toBeFocused() failed
Locator: getByRole('textbox', { name: 'Description' })
Expected: focused
Received: inactive
Timeout: 5000ms
Call log:
- Expect "toBeFocused" getByRole('textbox', { name: 'Description' }) with timeout 5000ms
- waiting for getByRole('textbox', { name: 'Description' })
14 Γ locator resolved to <textarea rows="5" required="" id="message" name="message" autofocus="true" class="form__input form__input--textarea" placeholder="What's the bug? What did you expect?"></textarea>
- unexpected value "inactive"
105 | form.open();
106 | });
> 107 | await expect(page.getByRole('textbox', { name: 'Description' })).toBeFocused();
| ^
108 | await form.evaluate((form, remove) => (remove ? form.removeFromDom() : form.close()), remove);
109 | await expect(page.locator('dialog:modal')).toHaveCount(0);
110 | await expect(launcher).toBeFocused();
at /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/suites/feedback/accessibility/test.ts:107:72
|
|
[webkit] βΊ suites/feedback/accessibility/test.ts:11:11 βΊ names the native modal and restores focus after repeated keyboard dismissal @firefox:
dev-packages/browser-integration-tests/suites/feedback/accessibility/test.ts#L22
1) [webkit] βΊ suites/feedback/accessibility/test.ts:11:11 βΊ names the native modal and restores focus after repeated keyboard dismissal @Firefox
Error: expect(locator).toBeFocused() failed
Locator: getByRole('textbox', { name: 'Description' })
Expected: focused
Received: inactive
Timeout: 5000ms
Call log:
- Expect "toBeFocused" getByRole('textbox', { name: 'Description' }) with timeout 5000ms
- waiting for getByRole('textbox', { name: 'Description' })
14 Γ locator resolved to <textarea rows="5" required="" id="message" name="message" autofocus="true" class="form__input form__input--textarea" placeholder="What's the bug? What did you expect?"></textarea>
- unexpected value "inactive"
20 | await expect(dialog).toHaveJSProperty('open', true);
21 | expect(await dialog.evaluate(el => el.matches(':modal'))).toBe(true);
> 22 | await expect(page.getByRole('textbox', { name: 'Description' })).toBeFocused();
| ^
23 |
24 | await page.locator('#background').evaluate(el => (el as HTMLElement).focus());
25 | await expect(page.getByRole('textbox', { name: 'Description' })).toBeFocused();
at /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/suites/feedback/accessibility/test.ts:22:70
|
|
All required jobs passed or were skipped
Process completed with exit code 1.
|
|
E2E nuxt-5 (tunnel-basepath) Test
No files were found with the provided path: /home/runner/work/_temp/test-application/test-results. No artifacts will be uploaded.
|
|
Size Check
Unable to update PR comments. The size report is available in the job summary.
|
|
π Playwright Run Summary
331 skipped
25 passed (15.5s)
|
|
π Playwright Run Summary
5 skipped
25 passed (11.0s)
|
|
π Playwright Run Summary
8 skipped
22 passed (10.4s)
|
|
π Playwright Run Summary
333 skipped
23 passed (17.0s)
|
|
π Playwright Run Summary
7 skipped
23 passed (7.9s)
|
|
π Playwright Run Summary
5 skipped
25 passed (14.3s)
|
|
π Playwright Run Summary
182 skipped
179 passed (21.1s)
|
|
π Playwright Run Summary
177 skipped
184 passed (23.3s)
|
|
π Playwright Run Summary
178 skipped
183 passed (22.3s)
|
|
π Playwright Run Summary
1 skipped
29 passed (18.7s)
|
|
π Playwright Run Summary
24 passed (20.0s)
|
|
π Playwright Run Summary
89 skipped
272 passed (28.2s)
|
|
π Playwright Run Summary
7 skipped
23 passed (8.9s)
|
|
π Playwright Run Summary
331 skipped
25 passed (19.5s)
|
|
π Playwright Run Summary
4 skipped
26 passed (19.0s)
|
|
π Playwright Run Summary
286 skipped
70 passed (32.5s)
|
|
π Playwright Run Summary
136 skipped
225 passed (37.7s)
|
|
π Playwright Run Summary
41 skipped
320 passed (40.0s)
|
|
π Playwright Run Summary
41 skipped
320 passed (42.5s)
|
|
π Playwright Run Summary
42 skipped
319 passed (42.4s)
|
|
π Playwright Run Summary
286 skipped
70 passed (35.2s)
|
|
π Playwright Run Summary
134 skipped
227 passed (37.7s)
|
|
π Playwright Run Summary
88 skipped
273 passed (37.8s)
|
|
π Playwright Run Summary
2 passed (5.3s)
|
|
π Playwright Run Summary
1 passed (3.8s)
|
|
π Playwright Run Summary
1 skipped
1 passed (5.0s)
|
|
π Playwright Run Summary
2 passed (3.4s)
|
|
π Playwright Run Summary
1 passed (4.4s)
|
|
π Playwright Run Summary
3 passed (4.3s)
|
|
π Playwright Run Summary
8 passed (9.3s)
|
|
π Playwright Run Summary
3 passed (2.2s)
|
|
π Playwright Run Summary
4 passed (4.8s)
|
|
π Playwright Run Summary
3 passed (3.9s)
|
|
π Playwright Run Summary
2 passed (8.4s)
|
|
π Playwright Run Summary
43 skipped
318 passed (53.2s)
|
|
π Playwright Run Summary
4 passed (8.8s)
|
|
π Playwright Run Summary
3 passed (7.4s)
|
|
π Playwright Run Summary
1 skipped
3 passed (4.7s)
|
|
π Playwright Run Summary
4 passed (3.1s)
|
|
π Playwright Run Summary
6 passed (13.1s)
|
|
π Playwright Run Summary
2 passed (3.0s)
|
|
π Playwright Run Summary
5 passed (13.0s)
|
|
π Playwright Run Summary
2 passed (3.2s)
|
|
π Playwright Run Summary
4 passed (3.3s)
|
|
π Playwright Run Summary
1 passed (3.0s)
|
|
π Playwright Run Summary
7 passed (8.9s)
|
|
π Playwright Run Summary
1 passed (3.8s)
|
|
π Playwright Run Summary
6 passed (12.9s)
|
|
π Playwright Run Summary
4 passed (6.3s)
|
|
π Playwright Run Summary
8 passed (9.6s)
|
|
π Playwright Run Summary
2 passed (3.0s)
|
|
π Playwright Run Summary
3 passed (2.2s)
|
|
π Playwright Run Summary
1 passed (9.0s)
|
|
π Playwright Run Summary
1 passed (6.2s)
|
|
π Playwright Run Summary
24 skipped
3 passed (3.1s)
|
|
π Playwright Run Summary
7 passed (4.4s)
|
|
π Playwright Run Summary
3 skipped
22 passed (13.7s)
|
|
π Playwright Run Summary
4 passed (3.1s)
|
|
π Playwright Run Summary
11 skipped
2 passed (3.4s)
|
|
π Playwright Run Summary
1 passed (7.2s)
|
|
π Playwright Run Summary
8 passed (7.7s)
|
|
π Playwright Run Summary
5 skipped
175 passed (1.2m)
|
|
π Playwright Run Summary
5 passed (8.3s)
|
|
π Playwright Run Summary
2 passed (3.3s)
|
|
π Playwright Run Summary
2 passed (3.8s)
|
|
π Playwright Run Summary
4 passed (8.9s)
|
|
π Playwright Run Summary
5 passed (10.6s)
|
|
π Playwright Run Summary
5 passed (10.0s)
|
|
π Playwright Run Summary
5 passed (7.9s)
|
|
π Playwright Run Summary
12 passed (6.1s)
|
|
π Playwright Run Summary
10 passed (9.9s)
|
|
π Playwright Run Summary
3 passed (5.2s)
|
|
π Playwright Run Summary
5 passed (11.7s)
|
|
π Playwright Run Summary
5 passed (9.8s)
|
|
π Playwright Run Summary
24 skipped
3 passed (2.9s)
|
|
π Playwright Run Summary
4 passed (3.1s)
|
|
π Playwright Run Summary
4 passed (10.3s)
|
|
π Playwright Run Summary
5 passed (7.6s)
|
|
π Playwright Run Summary
10 passed (12.7s)
|
|
π Playwright Run Summary
1 passed (1.8s)
|
|
π Playwright Run Summary
4 passed (11.5s)
|
|
π Playwright Run Summary
5 passed (13.7s)
|
|
π Playwright Run Summary
8 skipped
6 passed (11.2s)
|
|
π Playwright Run Summary
12 passed (19.3s)
|
|
π Playwright Run Summary
24 skipped
3 passed (5.1s)
|
|
π Playwright Run Summary
9 passed (10.7s)
|
|
π Playwright Run Summary
9 passed (14.6s)
|
|
π Playwright Run Summary
4 skipped
10 passed (16.2s)
|
|
π Playwright Run Summary
19 passed (29.9s)
|
|
π Playwright Run Summary
4 passed (12.3s)
|
|
π Playwright Run Summary
6 passed (13.1s)
|
|
π Playwright Run Summary
2 skipped
22 passed (18.2s)
|
|
π Playwright Run Summary
62 skipped
294 passed (1.5m)
|
|
π Playwright Run Summary
1 passed (32.5s)
|
|
π Playwright Run Summary
9 passed (10.8s)
|
|
π Playwright Run Summary
9 passed (10.7s)
|
|
π Playwright Run Summary
6 passed (34.3s)
|
|
π Playwright Run Summary
9 passed (15.6s)
|
|
π Playwright Run Summary
5 passed (10.7s)
|
|
π Playwright Run Summary
13 passed (30.7s)
|
|
π Playwright Run Summary
11 passed (19.9s)
|
|
π Playwright Run Summary
15 passed (31.2s)
|
|
π Playwright Run Summary
1 skipped
12 passed (26.5s)
|
|
π Playwright Run Summary
1 passed (28.2s)
|
|
π Playwright Run Summary
15 passed (30.9s)
|
|
π Playwright Run Summary
54 passed (34.1s)
|
|
π Playwright Run Summary
12 passed (19.2s)
|
|
π Playwright Run Summary
12 passed (34.8s)
|
|
π Playwright Run Summary
15 passed (28.7s)
|
|
π Playwright Run Summary
2 skipped
7 passed (31.7s)
|
|
π Playwright Run Summary
64 skipped
292 passed (1.5m)
|
|
π Playwright Run Summary
11 passed (20.0s)
|
|
π Playwright Run Summary
12 passed (32.1s)
|
|
π Playwright Run Summary
15 passed (40.6s)
|
|
π Playwright Run Summary
2 skipped
2 passed (31.0s)
|
|
π Playwright Run Summary
2 passed (45.4s)
|
|
π Playwright Run Summary
2 skipped
18 passed (34.3s)
|
|
π Playwright Run Summary
15 passed (41.9s)
|
|
π Playwright Run Summary
9 passed (32.2s)
|
|
π Playwright Run Summary
1 passed (34.4s)
|
|
π Playwright Run Summary
18 skipped
338 passed (1.7m)
|
|
π Playwright Run Summary
12 passed (40.2s)
|
|
π Playwright Run Summary
12 passed (40.0s)
|
|
π Playwright Run Summary
9 passed (36.3s)
|
|
π Playwright Run Summary
10 passed (40.0s)
|
|
π Playwright Run Summary
1 skipped
5 passed (19.2s)
|
|
π Playwright Run Summary
1 skipped
5 passed (13.8s)
|
|
π Playwright Run Summary
6 passed (46.4s)
|
|
π Playwright Run Summary
4 passed (3.5s)
|
|
π Playwright Run Summary
10 passed (19.3s)
|
|
π Playwright Run Summary
10 passed (12.5s)
|
|
π Playwright Run Summary
22 passed (41.5s)
|
|
π Playwright Run Summary
4 skipped
175 passed (1.8m)
|
|
π Playwright Run Summary
2 passed (29.3s)
|
|
π Playwright Run Summary
3 passed (38.8s)
|
|
π Playwright Run Summary
16 skipped
340 passed (1.9m)
|
|
π Playwright Run Summary
2 skipped
4 passed (16.8s)
|
|
π Playwright Run Summary
2 skipped
4 passed (11.6s)
|
|
π Playwright Run Summary
40 passed (34.5s)
|
|
π Playwright Run Summary
13 passed (42.8s)
|
|
π Playwright Run Summary
22 passed (50.2s)
|
|
π Playwright Run Summary
16 skipped
340 passed (1.8m)
|
|
π Playwright Run Summary
12 passed (42.1s)
|
|
π Playwright Run Summary
17 skipped
339 passed (1.8m)
|
|
π Playwright Run Summary
1 passed (36.6s)
|
|
π Playwright Run Summary
2 failed
[webkit] βΊ suites/feedback/accessibility/test.ts:11:11 βΊ names the native modal and restores focus after repeated keyboard dismissal @Firefox
[webkit] βΊ suites/feedback/accessibility/test.ts:89:11 βΊ programmatic close and removal release modal state and preserve body overflow @Firefox
108 skipped
251 passed (1.0m)
|
|
π Playwright Run Summary
15 passed (42.8s)
|
|
π Playwright Run Summary
10 passed (19.6s)
|
|
π Playwright Run Summary
10 passed (5.5s)
|
|
π Playwright Run Summary
22 passed (46.1s)
|
|
π Playwright Run Summary
18 skipped
338 passed (1.7m)
|
|
π Playwright Run Summary
1 passed (43.6s)
|
|
π Playwright Run Summary
1 passed (32.9s)
|
|
π Playwright Run Summary
11 passed (37.8s)
|
|
π Playwright Run Summary
10 passed (40.8s)
|
|
π Playwright Run Summary
2 skipped
4 passed (19.0s)
|
|
π Playwright Run Summary
2 skipped
4 passed (12.1s)
|
|
π Playwright Run Summary
1 skipped
11 passed (45.6s)
|
|
π Playwright Run Summary
2 passed (16.0s)
|
|
π Playwright Run Summary
13 passed (36.8s)
|
|
π Playwright Run Summary
2 passed (16.2s)
|
|
π Playwright Run Summary
13 passed (35.2s)
|
|
π Playwright Run Summary
10 passed (52.6s)
|
|
π Playwright Run Summary
83 skipped
273 passed (1.7m)
|
|
π Playwright Run Summary
179 passed (1.8m)
|
|
π Playwright Run Summary
6 skipped
173 passed (2.1m)
|
|
π Playwright Run Summary
6 skipped
7 passed (30.9s)
|
|
π Playwright Run Summary
13 passed (19.1s)
|
|
π Playwright Run Summary
4 skipped
12 passed (26.3s)
|
|
π Playwright Run Summary
2 skipped
14 passed (13.7s)
|
|
π Playwright Run Summary
16 passed (1.3m)
|
|
π Playwright Run Summary
2 passed (16.5s)
|
|
π Playwright Run Summary
2 skipped
25 passed (46.5s)
|
|
π Playwright Run Summary
3 passed (30.5s)
|
|
π Playwright Run Summary
3 passed (4.3s)
|
|
π Playwright Run Summary
3 skipped
28 passed (1.1m)
|
|
π Playwright Run Summary
2 passed (15.5s)
|
|
π Playwright Run Summary
19 passed (54.9s)
|
|
π Playwright Run Summary
2 passed (17.8s)
|
|
π Playwright Run Summary
2 skipped
21 passed (51.7s)
|
|
π Playwright Run Summary
2 passed (43.3s)
|
|
π Playwright Run Summary
2 passed (20.3s)
|
|
π Playwright Run Summary
2 passed (51.3s)
|
|
π Playwright Run Summary
2 passed (16.2s)
|
|
π Playwright Run Summary
1 skipped
11 passed (39.5s)
|
|
π Playwright Run Summary
17 passed (1.0m)
|
|
π Playwright Run Summary
4 passed (33.5s)
|
|
π Playwright Run Summary
4 passed (10.0s)
|
|
π Playwright Run Summary
2 skipped
29 passed (1.2m)
|
|
π Playwright Run Summary
1 skipped
30 passed (1.3m)
|
|
π Playwright Run Summary
1 skipped
30 passed (1.3m)
|
|
π Playwright Run Summary
4 skipped
12 passed (31.0s)
|
|
π Playwright Run Summary
2 skipped
14 passed (14.4s)
|
|
π Playwright Run Summary
2 skipped
29 passed (1.3m)
|
|
π Playwright Run Summary
10 passed (41.8s)
|
|
π Playwright Run Summary
10 passed (16.9s)
|
|
π Playwright Run Summary
13 passed (39.6s)
|
|
π Playwright Run Summary
13 passed (15.1s)
|
|
π Playwright Run Summary
9 skipped
18 passed (35.5s)
|
|
π Playwright Run Summary
1 skipped
26 passed (29.2s)
|
|
π Playwright Run Summary
2 passed (18.4s)
|
|
π Playwright Run Summary
2 skipped
25 passed (49.1s)
|
|
π Playwright Run Summary
5 skipped
42 passed (1.3m)
|
|
π Playwright Run Summary
2 passed (16.2s)
|
|
π Playwright Run Summary
19 passed (1.1m)
|
|
π Playwright Run Summary
8 skipped
17 passed (37.7s)
|
|
π Playwright Run Summary
1 skipped
24 passed (42.0s)
|
|
π Playwright Run Summary
2 skipped
4 passed (38.8s)
|
|
π Playwright Run Summary
2 skipped
4 passed (12.2s)
|
|
π Playwright Run Summary
4 skipped
31 passed (49.1s)
|
|
π Playwright Run Summary
1 skipped
5 passed (40.8s)
|
|
π Playwright Run Summary
1 skipped
5 passed (17.2s)
|
|
π Playwright Run Summary
13 skipped
57 passed (1.5m)
|
|
π Playwright Run Summary
30 skipped
40 passed (1.7m)
|
|
π Playwright Run Summary
19 skipped
28 passed (1.7m)
|
|
π Playwright Run Summary
11 skipped
59 passed (1.4m)
|
|
π Playwright Run Summary
6 skipped
7 passed (48.2s)
|
|
π Playwright Run Summary
13 passed (17.4s)
|
|
π Playwright Run Summary
29 skipped
41 passed (1.9m)
|
|
π Playwright Run Summary
8 skipped
27 passed (2.0m)
|
|
π Playwright Run Summary
13 skipped
57 passed (1.5m)
|
|
π Playwright Run Summary
14 skipped
56 passed (1.6m)
|
|
π Playwright Run Summary
8 skipped
17 passed (54.3s)
|
|
π Playwright Run Summary
1 skipped
24 passed (38.9s)
|
|
π Playwright Run Summary
2 skipped
32 passed (1.3m)
|
|
π Playwright Run Summary
2 skipped
32 passed (1.2m)
|
|
π Playwright Run Summary
15 skipped
55 passed (1.4m)
|
|
π Playwright Run Summary
30 skipped
40 passed (2.0m)
|
|
π Playwright Run Summary
1 skipped
5 passed (22.0s)
|
|
π Playwright Run Summary
58 passed (1.6m)
|
|
π Playwright Run Summary
52 skipped
28 passed (2.3m)
|
|
π Playwright Run Summary
13 skipped
57 passed (1.5m)
|
|
π Playwright Run Summary
1 skipped
5 passed (23.7s)
|
|
π Playwright Run Summary
58 passed (1.6m)
|
|
π Playwright Run Summary
9 skipped
18 passed (1.3m)
|
|
π Playwright Run Summary
1 skipped
26 passed (28.9s)
|
|
π Playwright Run Summary
13 skipped
57 passed (1.5m)
|
|
π Playwright Run Summary
2 skipped
32 passed (2.6m)
|
|
π Playwright Run Summary
44 passed (2.6m)
|
|
π Playwright Run Summary
2 skipped
32 passed (2.7m)
|
|
π Playwright Run Summary
27 skipped
43 passed (2.8m)
|
|
π Playwright Run Summary
2 skipped
78 passed (2.4m)
|
|
π Playwright Run Summary
43 skipped
318 passed (51.3s)
|
|
π Playwright Run Summary
1 skipped
7 passed (24.1s)
|
|
π Playwright Run Summary
2 skipped
78 passed (2.3m)
|
|
π Playwright Run Summary
1 skipped
7 passed (29.4s)
|
|
π Playwright Run Summary
2 skipped
78 passed (2.3m)
|
|
π Playwright Run Summary
27 skipped
43 passed (3.7m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
playwright-traces-job_browser_playwright_tests-bundle_tracing_replay_feedback_logs_metrics_min-webkit-1
|
444 KB |
sha256:a083063422a0e1e4d985af3c81f270436bccc0705b5cb2e1e79083e1af0c39c3
|
|