From 09ac2d83e3c615ef94b22bb7b6bf95ec9bcc1b74 Mon Sep 17 00:00:00 2001 From: Mark Lee Date: Thu, 28 May 2026 12:15:38 -0700 Subject: [PATCH 1/3] fix(release): set up gh-based git credentials --- shell/ci/release/pre-release.sh | 2 ++ shell/ci/release/release.sh | 2 ++ 2 files changed, 4 insertions(+) diff --git a/shell/ci/release/pre-release.sh b/shell/ci/release/pre-release.sh index 70356c9a5..7dea34c82 100755 --- a/shell/ci/release/pre-release.sh +++ b/shell/ci/release/pre-release.sh @@ -70,6 +70,8 @@ if [[ $CIRCLE_BRANCH != "$prereleasesBranch" ]] && [[ $DRYRUN == "false" ]]; the exit 0 fi +run_gh auth setup-git + # If we're in dry-run mode, skip creating the release. if [[ $DRYRUN == "true" ]]; then exit 0 diff --git a/shell/ci/release/release.sh b/shell/ci/release/release.sh index 3a4e6e845..8c635357c 100755 --- a/shell/ci/release/release.sh +++ b/shell/ci/release/release.sh @@ -17,6 +17,8 @@ if [[ -z $GITHUB_TOKEN ]]; then error "Failed to read GitHub personal access token" fi +run_gh auth setup-git + send_failure_notification() { if [[ -z $RELEASE_FAILURE_SLACK_CHANNEL ]]; then fatal "Failed to release" From b5454814099c34be368fac1c1427ff47372f8b84 Mon Sep 17 00:00:00 2001 From: Mark Lee Date: Thu, 28 May 2026 12:27:44 -0700 Subject: [PATCH 2/3] Add to dryrun script too --- shell/ci/release/dryrun.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/shell/ci/release/dryrun.sh b/shell/ci/release/dryrun.sh index bf9b95f74..312d8ce87 100755 --- a/shell/ci/release/dryrun.sh +++ b/shell/ci/release/dryrun.sh @@ -63,6 +63,8 @@ if ! git diff --quiet "$OLD_CIRCLE_BRANCH"; then warn "Failed to read Github personal access token" >&2 fi + run_gh auth setup-git + MISE_GITHUB_TOKEN="$GITHUB_TOKEN" GH_TOKEN="$GITHUB_TOKEN" \ yarn --frozen-lockfile semantic-release --dry-run From c401794deaa3791eff861ba99564ae608cd40191 Mon Sep 17 00:00:00 2001 From: Mark Lee Date: Thu, 28 May 2026 12:39:43 -0700 Subject: [PATCH 3/3] chore: fix poorly worded error messages --- shell/ci/release/dryrun.sh | 2 +- shell/ci/release/pre-release.sh | 2 +- shell/ci/release/release.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/shell/ci/release/dryrun.sh b/shell/ci/release/dryrun.sh index 312d8ce87..44ed113b3 100755 --- a/shell/ci/release/dryrun.sh +++ b/shell/ci/release/dryrun.sh @@ -60,7 +60,7 @@ if ! git diff --quiet "$OLD_CIRCLE_BRANCH"; then GITHUB_TOKEN="$(github_token)" if [[ -z $GITHUB_TOKEN ]]; then - warn "Failed to read Github personal access token" >&2 + warn "Failed to read GitHub token" >&2 fi run_gh auth setup-git diff --git a/shell/ci/release/pre-release.sh b/shell/ci/release/pre-release.sh index 7dea34c82..564d79afd 100755 --- a/shell/ci/release/pre-release.sh +++ b/shell/ci/release/pre-release.sh @@ -87,7 +87,7 @@ if [[ $COMMIT_MESSAGE =~ "chore: Release" ]]; then # Retrieve the GH_TOKEN GH_TOKEN=$(github_token) if [[ -z $GH_TOKEN ]]; then - echo "Failed to read Github personal access token" >&2 + echo "Failed to read GitHub token" >&2 fi # Unset NPM_TOKEN to force it to use the configured ~/.npmrc NPM_TOKEN='' GH_TOKEN=$GH_TOKEN \ diff --git a/shell/ci/release/release.sh b/shell/ci/release/release.sh index 8c635357c..91e55cfad 100755 --- a/shell/ci/release/release.sh +++ b/shell/ci/release/release.sh @@ -14,7 +14,7 @@ source "${LIB_DIR}/logging.sh" # Retrieve the GH_TOKEN GITHUB_TOKEN="$(github_token)" if [[ -z $GITHUB_TOKEN ]]; then - error "Failed to read GitHub personal access token" + error "Failed to read GitHub token" fi run_gh auth setup-git