From 70698be3b33cc4c42cb10596a24289dd63a943cd Mon Sep 17 00:00:00 2001 From: Rod Vince Date: Wed, 7 Oct 2026 21:44:33 -0600 Subject: [PATCH] fix: the hint beside a refusal says where the cure is, when it is not in the file MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The landing gate refuses an operation whose run() the house cannot hand what it takes, and writes out the edit of the plugin's entry that cures it. Beside that refusal the trial's summary said «Resubmit the complete corrected file with implement… edit with source would be refused»: two instructions for one refusal, and the summary's comes first (greenhouse evidence/1156). Two refusals say themselves what cures them, and neither cure is a corrected body: an operation the house cannot hand what it takes (phase collaborators), and a judge red over operations that are still scaffolds (phase behavior, with the scaffolds the gate named). For those the hint now says the file can be right as it is, where the cure is, and to send the same implement again. Every other rejection keeps the hint it had, and so does the parts door. --- src/Agent/TrialFailureSummary.php | 30 +++++++++++ tests/Agent/TrialFailureSummaryTest.php | 69 +++++++++++++++++++++++++ 2 files changed, 99 insertions(+) diff --git a/src/Agent/TrialFailureSummary.php b/src/Agent/TrialFailureSummary.php index a9ec0449..56dad722 100644 --- a/src/Agent/TrialFailureSummary.php +++ b/src/Agent/TrialFailureSummary.php @@ -89,6 +89,21 @@ private static function next(string $operation, ?string $mode, array $diagnostic . '; promote the accepted amendment, then call finish again. Do not repeat finish unchanged.'; } if ($operation === 'implement') { + // WHEN THE CURE IS NOT IN THE FILE, THE HINT DOES NOT SEND THE AGENT BACK TO THE FILE (greenhouse + // evidence/1156). Two refusals of the landing gate say themselves what cures them, and neither cure is + // a corrected body: beside them «resubmit the corrected file» is a second instruction, and it came first. + $phase = $diagnostic['phase'] ?? null; + if ($phase === 'collaborators') { + return 'This file can be right as it is: what run() takes is handed by the entry that lists the ' + . 'operation in its plugin, not by this class. Make the edit this refusal writes out on the plugin ' + . 'class — a plain edit with find and replace, and no source —, promote it, and send this same ' + . 'implement again.'; + } + if ($phase === 'behavior' && self::names($diagnostic['scaffolds'] ?? null)) { + return 'This file can be right as it is: its judge names operations that are still scaffolds, and no ' + . 'judge goes green over a scaffold. Fill and promote those first, in the order this refusal gives, ' + . 'and send this same implement again.'; + } // The construction judge can be right about the class and the cure still be elsewhere: what the // constructor asks for is registered in the plugin, and that lands on its own, first. $elsewhere = ($diagnostic['phase'] ?? null) === 'container' @@ -107,4 +122,19 @@ private static function next(string $operation, ?string $mode, array $diagnostic return 'Repair the named failure before running this test again.'; } + + /** Whether the gate named at least one thing, and nothing that is not a name. */ + private static function names(mixed $named): bool + { + if (!\is_array($named) || $named === [] || !array_is_list($named)) { + return false; + } + foreach ($named as $name) { + if (!\is_string($name) || $name === '') { + return false; + } + } + + return true; + } } diff --git a/tests/Agent/TrialFailureSummaryTest.php b/tests/Agent/TrialFailureSummaryTest.php index 165d832f..ad9321c4 100644 --- a/tests/Agent/TrialFailureSummaryTest.php +++ b/tests/Agent/TrialFailureSummaryTest.php @@ -95,4 +95,73 @@ public function testARejectionTheRecordedDoorRefusesIsSentToACompleteImplement() self::assertStringContainsString($elsewhere, $recorded); self::assertStringNotContainsString($elsewhere, TrialFailureSummary::from('implement', ['diagnostic' => ['phase' => 'behavior']], '', [])['next']); } + + /** + * WHEN THE CURE IS NOT IN THE FILE, THE HINT DOES NOT SEND THE AGENT BACK TO THE FILE (greenhouse + * evidence/1156). The landing gate refuses an operation whose `run()` the house cannot hand what it takes, and + * writes out the edit of the plugin's entry that cures it. Beside that refusal this summary said «Resubmit the + * complete corrected file… edit with source would be refused»: two instructions, and the house's own came first. + */ + public function testAnOperationTheHouseCannotHandWhatItTakesIsSentToItsPluginsEntry(): void + { + $output = ['error' => 'refused: the house cannot hand «GuardarCaja» what its run() works through', + 'diagnostic' => ['phase' => 'collaborators', 'submitted_sha256' => str_repeat('d', 64)]]; + + foreach ([false, true] as $recorded) { + $next = TrialFailureSummary::from('implement', $output, '', [], $recorded)['next']; + + self::assertStringStartsWith('This file can be right as it is', $next); + self::assertStringContainsString('what run() takes is handed by the entry that lists the operation in its plugin', $next); + self::assertStringContainsString('Make the edit this refusal writes out on the plugin class', $next); + self::assertStringContainsString('with find and replace, and no source', $next); + self::assertStringContainsString('promote it, and send this same implement again', $next); + self::assertStringNotContainsString('Resubmit the complete corrected file', $next); + self::assertStringNotContainsString('Repair the recorded proposal', $next); + self::assertStringNotContainsString('would be refused', $next); + } + } + + /** A judge red over operations that are still scaffolds is not cured in the body it judged. */ + public function testAJudgeRedOverScaffoldsIsSentToFillThemFirst(): void + { + $output = ['error' => 'refused: the class\'s own test judges this behavior red', + 'diagnostic' => ['phase' => 'behavior', 'submitted_sha256' => str_repeat('e', 64), 'scaffolds' => ['GuardarCaja']]]; + + foreach ([false, true] as $recorded) { + $next = TrialFailureSummary::from('implement', $output, '', [], $recorded)['next']; + + self::assertStringStartsWith('This file can be right as it is', $next); + self::assertStringContainsString('its judge names operations that are still scaffolds', $next); + self::assertStringContainsString('Fill and promote those first, in the order this refusal gives', $next); + self::assertStringContainsString('send this same implement again', $next); + self::assertStringNotContainsString('Repair the recorded proposal', $next); + self::assertStringNotContainsString('Resubmit the complete corrected file', $next); + } + } + + /** A judge red over no scaffold is about the body: the hint is the one it always was. */ + public function testAJudgeRedOverNoScaffoldKeepsItsHint(): void + { + $was = TrialFailureSummary::from('implement', ['diagnostic' => ['phase' => 'behavior', 'submitted_sha256' => str_repeat('f', 64)]], '', [], recorded: true)['next']; + self::assertStringStartsWith('Repair the recorded proposal with edit', $was); + + foreach ([[], 'GuardarCaja', [''], [7], ['GuardarCaja', null], ['class' => 'GuardarCaja'], null] as $scaffolds) { + $output = ['diagnostic' => ['phase' => 'behavior', 'submitted_sha256' => str_repeat('f', 64), 'scaffolds' => $scaffolds]]; + + self::assertSame($was, TrialFailureSummary::from('implement', $output, '', [], recorded: true)['next'], json_encode($scaffolds) ?: ''); + } + // And scaffolds named in another phase change nothing: only a judge runs over them. + $syntax = ['diagnostic' => ['phase' => 'syntax', 'scaffolds' => ['GuardarCaja']]]; + self::assertStringStartsWith('Resubmit the complete corrected file', TrialFailureSummary::from('implement', $syntax, '', [])['next']); + } + + /** The parts door keeps its own hint: a staged file is amended, whatever phase refused it. */ + public function testAFinishRefusedForTheSameReasonsKeepsTheAmendHint(): void + { + foreach ([['phase' => 'collaborators'], ['phase' => 'behavior', 'scaffolds' => ['GuardarCaja']]] as $diagnostic) { + $next = TrialFailureSummary::from('implement', ['diagnostic' => $diagnostic], '', ['mode' => 'finish'])['next']; + + self::assertStringStartsWith('Repair the staged file with implement mode=amend', $next); + } + } }