Skip to content

multi_embryo plan reads a stage attribute that does not exist #134

Description

@pskeshu

plans/multi_embryo.py:118-119 reads xy_stage._x_limits / ._y_limits. Neither attribute exists — the properties are x_limits (devices/stage.py:147) and y_limits (:152). The line raises AttributeError whenever that path executes.

Found while tracing the stage envelope for #107, not from the walkthrough recording — this path did not run during the demo.

Fix: use the real property names. Worth doing as part of #107, which consolidates the envelope into instance state read through those same two properties, so the three current read sites (stage.py:165-171, device_layer.py:362, this one) stop duplicating it.

Worth a test that exercises the multi-embryo plan far enough to touch the limits, since a typo'd attribute name is exactly what a smoke test catches and review does not.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghardwareHardware/device related

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions