fix: remove and ignore the include directory#5
Merged
Conversation
`cadmesh` builds both `assimp` and `tetgen`. The `compileCmesh` script indicates a preference for the `cadmesh` installation prefix to be the top-level `mlibary` source code directory; however, this top-level directory has an `include/` directory that _already_ contains some version of `assimp` and `tetgen` headers. This `include/` directory should be removed and not version controlled, in particular because old headers could get mixed with new ones here: https://github.com/gemc/mlibrary/blob/09addcd14af872a22bf92437aea841a1de910112/cadmesh/CMakeLists.txt#L74 This is especially painful if one builds `cadmesh` with `WITH_SYS_ASSIMP=ON`.
Contributor
|
thanks for catching that - somehow forgot to remove it when updating to use the latest assimp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cadmeshbuilds bothassimpandtetgen. ThecompileCmeshscript indicates a preference for thecadmeshinstallation prefix to be the top-levelmlibarysource code directory; however, this top-level directory has aninclude/directory that already contains some version ofassimpandtetgenheaders.This
include/directory should be removed and not version controlled, in particular because old headers could get mixed with new ones here:mlibrary/cadmesh/CMakeLists.txt
Line 74 in 09addcd
This is especially painful if one builds
cadmeshwithWITH_SYS_ASSIMP=ON.