diff --git a/archive/group2.gd b/archive/group2.gd index 600146e..78c9fc2 100644 --- a/archive/group2.gd +++ b/archive/group2.gd @@ -72,7 +72,6 @@ DeclareOperation( "ProjElWithFrobWithPSIsom", [IsMatrix and IsFFECollColl, IsMapping, IsField, IsGeneralMapping and IsSPGeneralMapping and IsOne] ); DeclareOperation( "ProjElsWithFrobWithPSIsom", [IsList, IsField] ); -DeclareAttribute( "Dimension", IsProjGroupWithFrobWithPSIsom ); DeclareProperty( "CanComputeActionOnPoints", IsProjGroupWithFrobWithPSIsom ); DeclareOperation( "CorrelationOfProjectiveSpace", [ IsList, IsField] ); DeclareOperation( "CorrelationOfProjectiveSpace", [ IsList, IsMapping, IsField] ); diff --git a/archive/group2.gi b/archive/group2.gi index f7a1945..0d92b98 100644 --- a/archive/group2.gi +++ b/archive/group2.gi @@ -1001,30 +1001,6 @@ InstallGlobalFunction( OnProjSubspacesExtended, return VectorSpaceToElement(ps,newvec); end ); -# CHECKED 19/09/11 jdb -############################################################################# -#O Dimension( ) -# returns the dimension of the correlation group . The dimension of this -# group is defined as the vector space dimension of the projective space -# of which was defined as a projective group, or, in other words, as the -# size of the matrices. -## -InstallMethod( Dimension, - "for a projective group with Frobenius with vspace isomorphism", - [IsProjGroupWithFrobWithPSIsom], - function( g ) - local gens; - if HasParent(g) then - return Dimension(Parent(g)); - fi; - # Now start to investigate: - gens := GeneratorsOfGroup(g); - if Length(gens) > 0 then - return Length(gens[1]!.mat); - fi; - Error("dimension could not be determined"); - end ); - # CHECKED 20/09/11 jdb ############################################################################# #P ActionOnAllPointsHyperplanes( ) diff --git a/doc/include/attributes_inventory.txt b/doc/include/attributes_inventory.txt index 40e8d03..04e84b7 100644 --- a/doc/include/attributes_inventory.txt +++ b/doc/include/attributes_inventory.txt @@ -30,10 +30,6 @@ A: ProjectiveDimension: IsElementOfLieGeometry A: ProjectiveDimension: IsEmptySubspace A: Dimension: IsLieGeometry -group.gd: attributes - -A: Dimension: IsProjectiveGroupWithFrob - projectivespace.gd: attributes A: ProjectivityGroup: IsProjectiveSpace @@ -48,7 +44,6 @@ A: StandardFrame: IsSubspaceOfProjectiveSpace correlations.gd: attributes -A: Dimension: IsProjGroupWithFrobWithPSIsom A: GramMatrix: IsPolarityOfProjectiveSpace A: CompanionAutomorphism: IsPolarityOfProjectiveSpace A: SesquilinearForm: IsPolarityOfProjectiveSpace diff --git a/doc/include/methods_inventory.txt b/doc/include/methods_inventory.txt index 20fb153..4e4de1a 100644 --- a/doc/include/methods_inventory.txt +++ b/doc/include/methods_inventory.txt @@ -219,7 +219,6 @@ M: ViewObj, [IsProjectiveGroupWithFrob and HasGeneratorsOfGroup], M: ViewObj, [IsProjectiveGroupWithFrob and HasSize], M: ViewObj, [IsProjectiveGroupWithFrob and HasGeneratorsOfGroup and HasSize], M: BaseField, [IsProjectiveGroupWithFrob], -M: Dimension, [IsProjectiveGroupWithFrob], M: OneImmutable, # was [IsGroup and IsProjectiveGroupWithFrob], I think might be M: CanComputeActionOnPoints, [IsProjectiveGroupWithFrob], M: ActionOnAllProjPoints, [ IsProjectiveGroupWithFrob ], @@ -413,7 +412,6 @@ M: MatrixOfCorrelation, InstallMethod(MatrixOfCorrelation,[IsProjGrpElWithFrobWi M: FieldAutomorphism, InstallMethod(FieldAutomorphism,[IsProjGrpElWithFrobWithPSIsomand IsProjGrpElWithFrobWithPSIsomRep], M: ProjectiveSpaceIsomorphism, InstallMethod(ProjectiveSpaceIsomorphism,[IsProjGrpElWithFrobWithPSIsomand IsProjGrpElWithFrobWithPSIsomRep], M: Embedding, [IsProjectiveGroupWithFrob, IsProjGroupWithFrobWithPSIsom], -M: Dimension, [IsProjGroupWithFrobWithPSIsom], M: ActionOnAllPointsHyperplanes, [ IsProjGroupWithFrobWithPSIsom ], M: CanComputeActionOnPoints, [IsProjGroupWithFrobWithPSIsom], M: NiceMonomorphism, [IsProjGroupWithFrobWithPSIsom and CanComputeActionOnPoints and IsHandledByNiceMonomorphism], 50, diff --git a/doc/projgroups.xml b/doc/projgroups.xml index 7d7eb84..56a2c73 100644 --- a/doc/projgroups.xml +++ b/doc/projgroups.xml @@ -619,6 +619,7 @@ the base field of the vector space on which the group acts. +
diff --git a/lib/correlations.gd b/lib/correlations.gd index bc69581..bf7e1b9 100644 --- a/lib/correlations.gd +++ b/lib/correlations.gd @@ -74,7 +74,6 @@ DeclareOperation( "ProjElWithFrobWithPSIsom", [IsMatrix and IsFFECollColl, IsMapping, IsField, IsGeneralMapping and IsSPGeneralMapping and IsOne] ); DeclareOperation( "ProjElsWithFrobWithPSIsom", [IsList, IsField] ); -DeclareAttribute( "Dimension", IsProjGroupWithFrobWithPSIsom ); DeclareProperty( "CanComputeActionOnPoints", IsProjGroupWithFrobWithPSIsom ); DeclareOperation( "CorrelationOfProjectiveSpace", [ IsList, IsField] ); diff --git a/lib/correlations.gi b/lib/correlations.gi index bc0bd9f..e6ac574 100644 --- a/lib/correlations.gi +++ b/lib/correlations.gi @@ -1340,30 +1340,6 @@ InstallGlobalFunction( OnProjSubspacesExtended, return VectorSpaceToElement(ps,newvec); end ); -# CHECKED 19/09/11 jdb -############################################################################# -#O Dimension( ) -# returns the dimension of the correlation group . The dimension of this -# group is defined as the vector space dimension of the projective space -# of which was defined as a projective group, or, in other words, as the -# size of the matrices. -## -InstallMethod( Dimension, - "for a projective group with Frobenius with vspace isomorphism", - [IsProjGroupWithFrobWithPSIsom], - function( g ) - local gens; - if HasParent(g) then - return Dimension(Parent(g)); - fi; - # Now start to investigate: - gens := GeneratorsOfGroup(g); - if Length(gens) > 0 then - return NrRows(gens[1]!.mat); - fi; - Error("dimension could not be determined"); - end ); - # CHECKED 20/09/11 jdb ############################################################################# #P ActionOnAllPointsHyperplanes( ) @@ -1414,7 +1390,7 @@ InstallMethod( CanComputeActionOnPoints, [IsProjGroupWithFrobWithPSIsom], function( g ) local d,q; - d := Dimension( g ); + d := NrRows(GeneratorsOfGroup(g)[1]!.mat);; q := Size( BaseField( g ) ); if (q^d - 1)/(q-1) > FINING.LimitForCanComputeActionOnPoints then return false; diff --git a/lib/group.gd b/lib/group.gd index 8fac25e..5b9584f 100644 --- a/lib/group.gd +++ b/lib/group.gd @@ -132,7 +132,6 @@ DeclareGlobalFunction( "OnProjSubspacesNoFrob" ); # as a projective semilinear group (i.e. a collineation group), and for these # groups we have the operations defined (ml 05/11/2012) #DeclareOperation( "ActionOnAllProjPoints", [IsProjectivityGroup] ); -#DeclareAttribute( "Dimension", IsProjectivityGroup ); #DeclareProperty( "CanComputeActionOnPoints", IsProjectivityGroup ); @@ -158,7 +157,6 @@ DeclareGlobalFunction( "OnProjSubspacesWithFrob" ); DeclareOperation( "ActionOnAllProjPoints", [IsProjectiveGroupWithFrob] ); -DeclareAttribute( "Dimension", IsProjectiveGroupWithFrob ); DeclareProperty( "CanComputeActionOnPoints", IsProjectiveGroupWithFrob ); DeclareGlobalFunction( "NiceMonomorphismByOrbit" ); diff --git a/lib/group.gi b/lib/group.gi index 1202213..2808a4b 100644 --- a/lib/group.gi +++ b/lib/group.gi @@ -1765,59 +1765,6 @@ InstallMethod( BaseField, # TO DO (22/03/2014): We ought to set the basefield on creating collineation groups. -# CHECKED 6/09/11 jdb -############################################################################# -#O Dimension( ) -# returns the dimension of the projective group . The dimension of this -# group is defined as the vector space dimension of the projective space -# of which was defined as a projective group, or, in other words, as the -# size of the matrices. -## - -# ml 07/11/2012: I have taken out the view, print and display methods -# for projectivity groups, since these are also collineation groups in FinInG - -#InstallMethod( Dimension, -# "for a projective group", -# [IsProjectivityGroup], -# function( g ) -# local gens; -# if HasParent(g) then -# return Dimension(Parent(g)); -# fi; - # # Now start to investigate: -# gens := GeneratorsOfGroup(g); -# if Length(gens) > 0 then -# return NrRows(gens[1]!.mat); -# fi; -# Error("dimension could not be determined"); -# end ); - -# CHECKED 6/09/11 jdb -############################################################################# -#O Dimension( ) -# returns the dimension of the projective collineation group . The dimension of this -# group is defined as the vector space dimension of the projective space -# of which was defined as a projective group, or, in other words, as the -# size of the matrices. -## -InstallMethod( Dimension, - "for a projective collineation group", - [IsProjectiveGroupWithFrob], - function( g ) - local gens; - if HasParent(g) and HasDimension(Parent(g)) then #JB: 22/03/2014: Made sure the parent had a dimension first - return Dimension(Parent(g)); - fi; - # Now start to investigate: - gens := GeneratorsOfGroup(g); - if Length(gens) > 0 then - return NrRows(gens[1]!.mat); - elif IsTrivial(g) then #JB: 22/03/2014: The trivial group with no generators slipped through. - return NrRows(One(g)!.mat); - fi; - Error("dimension could not be determined"); - end ); # CHECKED 6/09/11 jdb ############################################################################# @@ -1911,7 +1858,7 @@ InstallMethod( CanComputeActionOnPoints, [IsProjectiveGroupWithFrob], function( g ) local d,q; - d := Dimension( g ); + d := NrRows(GeneratorsOfGroup(g)[1]!.mat);; q := Size( BaseField( g ) ); if (q^d - 1)/(q-1) > FINING.LimitForCanComputeActionOnPoints then return false; @@ -2061,7 +2008,7 @@ InstallMethod( ActionOnAllProjPoints, local a,d,f,o,on,orb,v, m, j; Info(InfoFinInG,4,"Using ActionOnAllProjPoints"); f := BaseField(pg); - d := Dimension(pg); + d := NrRows(GeneratorsOfGroup(pg)[1]!.mat);; o := One(f); on := One(pg); v := ZeroMutable(on!.mat[1]); @@ -2326,7 +2273,7 @@ InstallMethod( FindBasePointCandidates, d := NrRows(gens[1]!.el!.mat); else f := BaseField(g); - d := Dimension(g); + d := NrRows(gens[1]!.mat); fi; cand := rec( points := NewMatrix(IsCMatRep, f,d, IdentityMat(d,f)), used := 0, ops := ListWithIdenticalEntries(d,OnProjPointsWithFrob) ); diff --git a/old/group2old.gd b/old/group2old.gd index 0e1991d..5dc9447 100644 --- a/old/group2old.gd +++ b/old/group2old.gd @@ -44,5 +44,4 @@ DeclareOperation( "ProjElWithFrobWithVSIsom", DeclareOperation( "ProjElsWithFrobWithVSIsom", [IsList, IsField] ); -DeclareAttribute( "Dimension", IsProjGroupWithFrobWithVSIsom ); DeclareProperty( "CanComputeActionOnPoints", IsProjGroupWithFrobWithVSIsom ); diff --git a/old/group2old.gi b/old/group2old.gi index f625d21..a941a2d 100644 --- a/old/group2old.gi +++ b/old/group2old.gi @@ -482,22 +482,6 @@ InstallGlobalFunction( OnPointsHyperplanesWithFrobWithVSIsom, fi; end ); -InstallMethod( Dimension, - "for a projective group with Frobenius with vspace isomorphism", - [IsProjGroupWithFrobWithVSIsom], - function( g ) - local gens; - if HasParent(g) then - return Dimension(Parent(g)); - fi; - # Now start to investigate: - gens := GeneratorsOfGroup(g); - if Length(gens) > 0 then - return Length(gens[1]!.mat); - fi; - Error("dimension could not be determined"); - end ); - InstallMethod( ActionOnPointsHyperplanes, "for a projective group with Frobenius with vspace isomorphism", [ IsProjGroupWithFrobWithVSIsom ],